[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Constantin Kronbichler via cfe-commits
ccrownhill wrote: Thank you very much for fixing that:) https://github.com/llvm/llvm-project/pull/98016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Constantin Kronbichler via cfe-commits
ccrownhill wrote: Ok, that's done with the FIXME comment for now. Maybe it is only because this is my first time contributing and I am not too familiar with the codebase but I couldn't see a trivial fix for the issue. For now I think it's best to land these changes first. I would just add an iss

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Constantin Kronbichler via cfe-commits
ccrownhill wrote: Sorry, my mistake. This doesn't work for `default` but the problem is that in this example ``` static void *f(void); void *k = _Generic(&f, void *(*)(void) : 0, int (*)(void) : f()); ``` the `undefined-internal` error is still raised even though it is not in the result expre

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Constantin Kronbichler via cfe-commits
ccrownhill wrote: Oh that makes sense so ``` static void f(); void *k = _Generic(&f, void (*)(void) : 0, default : f); ``` should be ok since it is not in the result expression? https://github.com/llvm/llvm-project/pull/98016 ___ cfe-commits mailing

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Constantin Kronbichler via cfe-commits
ccrownhill wrote: Since one error message will occlude others I had to split the files as I did in the latest commit. I have added one for the `_Alignof` case checking for the errors I was getting in godbolt while also checking that no `undefined-internal` error occurred. Lastly, I added the on

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Constantin Kronbichler via cfe-commits
https://github.com/ccrownhill updated https://github.com/llvm/llvm-project/pull/98016 >From 5dd2bb12dee26ba93d927ad1cd99fa610f9ace97 Mon Sep 17 00:00:00 2001 From: ccrownhill Date: Mon, 8 Jul 2024 11:42:37 +0100 Subject: [PATCH 1/4] fix bug that undefined internal is a warning only for -pedant

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Constantin Kronbichler via cfe-commits
ccrownhill wrote: Ah I see. Thank you for the suggestions! I also tried the same for `_Alignof` but was put off by the errors generated by the `-pedantic-errors` flag. But I guess I can just check that I don't get the `undefined-internal` error. For the other two I had something similar but tha

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-10 Thread Constantin Kronbichler via cfe-commits
ccrownhill wrote: I added three more tests covering these points: — part of the operand of a sizeof operator whose result is an integer constant; — part of the controlling expression of a generic selection; — or, part of the operand of any typeof operator whose result is not a variably modified

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-10 Thread Constantin Kronbichler via cfe-commits
https://github.com/ccrownhill updated https://github.com/llvm/llvm-project/pull/98016 >From 5dd2bb12dee26ba93d927ad1cd99fa610f9ace97 Mon Sep 17 00:00:00 2001 From: ccrownhill Date: Mon, 8 Jul 2024 11:42:37 +0100 Subject: [PATCH 1/3] fix bug that undefined internal is a warning only for -pedant

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-10 Thread Constantin Kronbichler via cfe-commits
ccrownhill wrote: That sounds good. I will have a look at that. https://github.com/llvm/llvm-project/pull/98016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-10 Thread Constantin Kronbichler via cfe-commits
https://github.com/ccrownhill updated https://github.com/llvm/llvm-project/pull/98016 >From 5dd2bb12dee26ba93d927ad1cd99fa610f9ace97 Mon Sep 17 00:00:00 2001 From: ccrownhill Date: Mon, 8 Jul 2024 11:42:37 +0100 Subject: [PATCH 1/2] fix bug that undefined internal is a warning only for -pedant

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-10 Thread Constantin Kronbichler via cfe-commits
ccrownhill wrote: Ok I just added a commit with the addition to `clang/docs/ReleaseNotes.rst`. https://github.com/llvm/llvm-project/pull/98016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-08 Thread Constantin Kronbichler via cfe-commits
https://github.com/ccrownhill created https://github.com/llvm/llvm-project/pull/98016 This fixes issue #39558 which mentions the problem when compiling the following code with `-pedantic-errors` flag (it also mentions `-Wall -Wextra` but those shouldn't change the output, which is also the cas