[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added a comment. In D59254#3298184 , @void wrote: > In D59254#1792134 , @connorkuehl > wrote: > >> In D59254#1792068 , @xbolva00 wrote: >> >>> Re-ping >> >> Stil

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added a comment. In D59254#1792068 , @xbolva00 wrote: > Re-ping Still under development here: https://github.com/connorkuehl/llvm-project/tree/randstruct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added a comment. In D59254#1429401 , @jfb wrote: > I find it easier to understand the code by looking at the tests. When you add > tests, please make sure you test for: > > - Bit-fields > - Zero-width bit-field Hi JF, Could you elaborate on

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added a comment. In D59254#1565961 , @jfb wrote: > Do you intend on moving this forward? It seems like a Good Thing overall, and > I'd love to help review some more. Yes. I'm sorry it's been in limbo so long. I haven't touched base with the

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added inline comments. Comment at: clang/include/clang/AST/RecordFieldReorganizer.h:54 + std::seed_seq Seq; + std::default_random_engine rng; +}; pcc wrote: > I don't think we can use `default_random_engine` for this because the > behaviour would n

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added a comment. In D59254#1426809 , @pcc wrote: > This needs a test under `test/CodeGen` at least. Will do, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59254/new/ https://reviews

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:1262 + // The last one in the chain should have a null next! + PrevDecl->NextInContextAndBits.setPointer(nullptr); + Apologies that this is included. I've left a comment on `clang/lib/AS

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl created this revision. Herald added subscribers: cfe-commits, jdoerfert, mgorny. Herald added a project: clang. This patch set introduces structure field layout randomization into the Clang compiler. The Randstruct feature is a compile-time hardening technique that randomizes the fiel