[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

2023-05-04 Thread Colin Ogilvie via Phabricator via cfe-commits
cogilvie added a comment. In D149643#4316128 , @MyDeveloperDay wrote: > Thanks for the patch...this tells me people are starting to use this feature > in anger!! i.e. your formatting via git-clang-format (which is brave!) ;-) > which means you have the

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

2023-05-04 Thread Colin Ogilvie via Phabricator via cfe-commits
cogilvie marked 2 inline comments as done. cogilvie added a comment. Fixed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

2023-05-04 Thread Colin Ogilvie via Phabricator via cfe-commits
cogilvie updated this revision to Diff 519389. cogilvie marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 Files: clang/lib/Format/QualifierAlignmentFixer.cpp clang/unittests/Format/QualifierFixerTest.cpp Ind

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

2023-05-03 Thread Colin Ogilvie via Phabricator via cfe-commits
cogilvie updated this revision to Diff 519008. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 Files: clang/lib/Format/QualifierAlignmentFixer.cpp clang/unittests/Format/QualifierFixerTest.cpp Index: clang/unittests/Format/QualifierFixerTe

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

2023-05-03 Thread Colin Ogilvie via Phabricator via cfe-commits
cogilvie updated this revision to Diff 519007. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149643/new/ https://reviews.llvm.org/D149643 Files: clang/lib/Format/QualifierAlignmentFixer.cpp clang/unittests/Format/QualifierFixerTest.cpp Index: clang/unittests/Format/QualifierFixerTe

[PATCH] D149643: Correctly limit formatted ranges when specifying qualifier alignment

2023-05-02 Thread Colin Ogilvie via Phabricator via cfe-commits
cogilvie created this revision. cogilvie added reviewers: MyDeveloperDay, rymiel, HazardyKnusperkeks, owenpan. cogilvie added a project: clang-format. Herald added projects: All, clang. cogilvie requested review of this revision. The qualifier alignment fixer appeared to ignore any ranges specifie