[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

colden added a comment. In https://reviews.llvm.org/D43700#1019506, @zturner wrote: > @rnk by "in an MSVC environment" do you mean "when -fms-compatibility is > present"? It looks like other places in this file are using `Triple.isWindowsMSVCEnvironment()`, which I think would make sense to u

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

colden added a comment. In https://reviews.llvm.org/D43700#1019505, @aganea wrote: > Thanks for fixing this @zturner. I simply want to back-up what @probinson > says above - most of the games we do at Ubisoft are currently using a > different compilation toolchains for each platform (we ship at

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

colden added a comment. In https://reviews.llvm.org/D43700#1018087, @zturner wrote: > In https://reviews.llvm.org/D43700#1018042, @colden wrote: > > > Seems good to me! I'll give it a test on my end. > > > > One alternate implementation idea though, what if you defaulted > > EmitCodeView to the

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

colden added a comment. Seems good to me! I'll give it a test on my end. One alternate implementation idea though, what if you defaulted EmitCodeView to the hasArg check instead of false, then removed the `else *EmitCodeView = false;` block on line 4999? https://reviews.llvm.org/D43700 ___

[PATCH] D42455: Don't create hidden dllimport global values

colden added a comment. Confirmed, this fixes my issue! Thanks! https://reviews.llvm.org/D42455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41032: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic

colden added a comment. Thanks Reid! Would you mind submitting this for me? https://reviews.llvm.org/D41032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41032: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic

colden marked an inline comment as done. colden added inline comments. Comment at: llvm/tools/clang/lib/CodeGen/CGBuiltin.cpp:8439 + +llvm::Type *Int128Ty = llvm::IntegerType::get(getLLVMContext(), 128); +llvm::Type *Int128PtrTy = Int128Ty->getPointerTo(); ---

[PATCH] D41032: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic

colden updated this revision to Diff 126641. colden added a comment. llvm::IntegerType::get(getLLVMContext(), 128) -> Builder.getInt128Ty() https://reviews.llvm.org/D41032 Files: llvm/tools/clang/include/clang/Basic/BuiltinsX86_64.def llvm/tools/clang/lib/CodeGen/CGBuiltin.cpp llvm/tools/

[PATCH] D41032: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic

colden updated this revision to Diff 126634. colden retitled this revision from "[CodeGen] Implement _InterlockedCompareExchange128 intrinsic" to "[CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic". colden added a comment. Moved implementation to X86_64 specific code, as accordin

[PATCH] D41032: [CodeGen] Implement _InterlockedCompareExchange128 intrinsic

colden created this revision. InterlockedCompareExchange128 is a bit more complicated than the other InterlockedCompareExchange functions, so it requires a bit more work. It doesn't directly refer to 128bit ints, instead it takes pointers to 64bit ints for Destination and ComparandResult, and e