[PATCH] D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs

cdevadas added inline comments. Comment at: clang/test/CodeGenHIP/shuffle-attr-verify.hip:34 +// CHECK-DAG: attributes #[[attr1]] = { {{[^}]*}}shuffle{{[^}]*}} } \ No newline at end of file Add a new line. Comment at: clang/test/CodeGenHIP/shu

[PATCH] D120566: [OpenCL][AMDGPU]: Do not allow a call to kernel

cdevadas created this revision. cdevadas added reviewers: rjmccall, Anastasia, yaxunl, arsenm. Herald added subscribers: Naghasan, ldrumm, kerbowa, t-tye, tpr, dstuttard, jvesely, kzhuravl. cdevadas requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a proj

[PATCH] D80931: AMDGPU: Fix clang side null pointer value for private

cdevadas accepted this revision. cdevadas added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80931/new/ https://reviews.llvm.org/D80931 ___ cfe-commits mailing list cfe-commi

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366683: Updated the signature for some stack related intrinsics (CLANG) (authored by cdevadas, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

cdevadas updated this revision to Diff 210648. cdevadas added a comment. Herald added a subscriber: jvesely. updated test/CodeGenOpenCL/builtins-generic-amdgcn.cl to vaildate the address space. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64563/new/ https://reviews.llvm.org/D64563 Fi

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

cdevadas updated this revision to Diff 209467. cdevadas added a comment. Added alloca address space. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64563/new/ https://reviews.llvm.org/D64563 Files: lib/CodeGen/CGBuiltin.cpp lib/CodeGen/CGException.cpp test/CodeGen/builtin-sponentr

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

cdevadas created this revision. cdevadas added a reviewer: arsenm. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. This patch includes the intrinsics int_addressofreturnaddress, int_frameaddress & int_sponentry. This patch should go along with the changes in https://re

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

This revision was automatically updated to reflect the committed changes. Closed by commit rL365643: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and… (authored by cdevadas, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

cdevadas added a comment. The backend changes, D63886 are in the upstream now with revision rL365217 . Please review this patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63756/new/ https:/

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

cdevadas added a comment. I have created the review for adding the metadata in the backend. https://reviews.llvm.org/D63886 Marking the current review depended on D63886 . Repository: rC Clang CHANGES SINCE LAST ACTION http

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

cdevadas added a comment. Hi Sam, The compiler generates metadata for the first 48 bytes. I compiled a sample code and verified it. The backend does nothing for the extra bytes now. I will soon submit the backend patch to generate the new metadata. Repository: rC Clang CHANGES SINCE LAST ACT

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

cdevadas created this revision. cdevadas added reviewers: yaxunl, b-sumner. Herald added subscribers: cfe-commits, t-tye, Anastasia, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. Herald added a project: clang. To enable a new implicit kernel argument, increasing the number of argument bytes

[PATCH] D62244: [AMDGPU] Enable the implicit arguments for HIP (CLANG)

cdevadas updated this revision to Diff 203975. cdevadas added a comment. simplified the check in the test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62244/new/ https://reviews.llvm.org/D62244 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenCUDA/amdgpu

[PATCH] D62244: [AMDGPU] Enable the implicit arguments for HIP (CLANG)

cdevadas updated this revision to Diff 200870. cdevadas added a comment. Herald added subscribers: nhaehnle, jvesely. Moved the test to CodeGenCUDA directory. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62244/new/ https://reviews.llvm.org/D62244 Files: lib/CodeGen/TargetInfo.cpp

[PATCH] D62244: [AMDGPU] Enable the implicit arguments for HIP (CLANG)

cdevadas created this revision. cdevadas added reviewers: b-sumner, yaxunl. Herald added subscribers: cfe-commits, t-tye, Anastasia, tpr, dstuttard, wdng, kzhuravl. Herald added a project: clang. Enable 48-bytes of implicit arguments for HIP as well. Earlier it was enabled for OpenCL. This code