[PATCH] D103377: [clangd] Add ability to change storage directory of index files

2021-06-01 Thread Christopher Rhodes via Phabricator via cfe-commits
crr0004 added a comment. Whoops. Hit close without adding this comment. Okay thank you for that @sammccall and @kadirect. Ultimately shared this patch was I found it useful but wasn't sure if it would fit with the project. Is there somewhere I can read about project direction/decisions? Like th

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

2021-05-31 Thread Christopher Rhodes via Phabricator via cfe-commits
crr0004 added a comment. Strictly speaking you could, assuming you have a compile database and it's okay to have copies or symlinks of the database. I would have probably done that if I had realised I could. That does speak to another issue though; moving the compile database to move the index

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

2021-05-30 Thread Christopher Rhodes via Phabricator via cfe-commits
crr0004 created this revision. crr0004 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. crr0004 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This adds a new option t

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

2021-04-22 Thread Christopher Rhodes via Phabricator via cfe-commits
crr0004 added a comment. One thing I noticed was that you need to be over the base class or overriding class identifier in order to get the code action. For some editors like Visual Studio Code this is less noticeable but for others like VIM it is more noticeable as you need to know it's there.