Hi Martin,
Actually I reread the developer policy,
(https://llvm.org/docs/DeveloperPolicy.html#id13). As I contributed this
code and take responsibility for it. It seems that I can approve this patch.
So it looks OK for me, sorry for the delay,
Cheers
Christian
On 10/02/2018 07:55 PM, Martin
Author: chrib
Date: Wed Sep 12 01:59:17 2018
New Revision: 342031
URL: http://llvm.org/viewvc/llvm-project?rev=342031&view=rev
Log:
Fix Check test to avoid output string mismatch
Differential Revision: http://reviews.llvm.org/D51354
Modified:
cfe/trunk/test/Driver/print-multi-directory.c
M
Author: chrib
Date: Thu Sep 6 07:03:44 2018
New Revision: 341547
URL: http://llvm.org/viewvc/llvm-project?rev=341547&view=rev
Log:
Fix the -print-multi-directory flag to print the selected multilib.
Summary: Fix -print-multi-directory to print the selected multilib
Reviewers: jroelofs
Reviewed
Understood, The test worked for me because I have both 64 bit and 32 bit libs
installed on my default sysroot. Otherwise might fail indeed.
Will amend the test with an explicit sysroot,
> -Original Message-
> From: Tim Shen via Phabricator [mailto:revi...@reviews.llvm.org]
> Sent: Wedn
Hello all,
Is there a way to see how the patch looked like after my commit and
before the revert from the git mirror ?
I cannot reproduce the test failure from the bots in my local build,
(which is based on the the git mirror). but I noticed that a similar
behavior however occurs when the test
Oh, yes, sure
Best Regards
Christian
On 09/05/2018 12:05 AM, Richard Smith wrote:
This is breaking buildbots:
http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/19509
Can you take a look? Thanks!
On Tue, 4 Sep 2018 at 08:36, Christian Bruel via cfe-commits
Author: chrib
Date: Tue Sep 4 08:22:13 2018
New Revision: 341373
URL: http://llvm.org/viewvc/llvm-project?rev=341373&view=rev
Log:
Fix the -print-multi-directory flag to print the selected multilib.
Summary: Fix -print-multi-directory to print the selected multilib
Reviewers: jroelofs
Reviewed
Hi Jon
Le 03/21/2017 à 09:11 PM, Jonathan Roelofs a écrit :
On 3/21/17 1:53 PM, Christian Bruel via Phabricator wrote:
chrib added a comment.
In https://reviews.llvm.org/D31140#706411, @jroelofs wrote:
Can you clarify the logic here? It's my understanding that:
`-fno-exceptions` does *no
Just to add to our comments bellow,
One experiment I did is to use the nounwind/uwtable combination to
achieve what we need.
e.g:
nounwind= emit nothing
nounwind uwtable = emit the .exidx .extab section with the CANTUNWIND
However I gave that up because of tests legacy. e.g
