https://github.com/whiteio updated
https://github.com/llvm/llvm-project/pull/120644
>From 2d6d43abf0dfaa64a5cdd7bff3a3ecbef01635c2 Mon Sep 17 00:00:00 2001
From: Chris White
Date: Thu, 19 Dec 2024 22:02:47 +
Subject: [PATCH 1/2] [Clang-CL][DXC] Expose -fdiagnostic-color= to clang-cl
and cl
whiteio wrote:
Thanks @Maetveis, I've addressed the comments.
https://github.com/llvm/llvm-project/pull/120644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/whiteio updated
https://github.com/llvm/llvm-project/pull/120644
>From 770dec5aec1b879bafbc6c69b12a2e43c9497f7f Mon Sep 17 00:00:00 2001
From: Chris White
Date: Thu, 19 Dec 2024 22:02:47 +
Subject: [PATCH 1/2] [Clang-CL][DXC] Expose -fdiagnostic-color= to clang-cl
and cl
https://github.com/whiteio updated
https://github.com/llvm/llvm-project/pull/120644
>From 770dec5aec1b879bafbc6c69b12a2e43c9497f7f Mon Sep 17 00:00:00 2001
From: Chris White
Date: Thu, 19 Dec 2024 22:02:47 +
Subject: [PATCH] [Clang-CL][DXC] Expose -fdiagnostic-color= to clang-cl and
clang-
https://github.com/whiteio created
https://github.com/llvm/llvm-project/pull/120644
Exposing `-fdiagnostic-color=` to clang-cl and clang-dxc. `-fcolor-diagnostics`
and `-fno-color-diagnostics` are already allowed in both of these and
`-fdiagnostics-color=` allows one additional value, `auto`.
whiteio wrote:
@Maetveis I've disabled that settings now. Thanks!
https://github.com/llvm/llvm-project/pull/116871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
whiteio wrote:
Hey @Maetveis, I've addressed the conflicts 👍
https://github.com/llvm/llvm-project/pull/116871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/whiteio updated
https://github.com/llvm/llvm-project/pull/116871
>From 29330456191334afb6cd82ae44f496c522985877 Mon Sep 17 00:00:00 2001
From: Chris White
Date: Tue, 19 Nov 2024 20:06:28 +
Subject: [PATCH 1/3] [Clang] Fix -Wunused-private-field false negative with
defaul
https://github.com/whiteio updated
https://github.com/llvm/llvm-project/pull/116871
>From 29330456191334afb6cd82ae44f496c522985877 Mon Sep 17 00:00:00 2001
From: Chris White
Date: Tue, 19 Nov 2024 20:06:28 +
Subject: [PATCH 1/3] [Clang] Fix -Wunused-private-field false negative with
defaul
whiteio wrote:
@Maetveis Thanks for letting me know, I'll resolve the conflicts and let you
know once they're resolved.
https://github.com/llvm/llvm-project/pull/116871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
whiteio wrote:
Thanks for that @Maetveis! I've updated the release notes.
https://github.com/llvm/llvm-project/pull/116871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/whiteio updated
https://github.com/llvm/llvm-project/pull/116871
>From ad14635ab12eb81a841db885962c95911722e4f2 Mon Sep 17 00:00:00 2001
From: Chris White
Date: Tue, 19 Nov 2024 20:06:28 +
Subject: [PATCH 1/3] [Clang] Fix -Wunused-private-field false negative with
defaul
https://github.com/whiteio edited
https://github.com/llvm/llvm-project/pull/116871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/whiteio updated
https://github.com/llvm/llvm-project/pull/116871
>From c69426607d63b3a0cf7d839c82cde55273a5f942 Mon Sep 17 00:00:00 2001
From: Chris White
Date: Tue, 19 Nov 2024 20:06:28 +
Subject: [PATCH 1/2] [Clang] Fix -Wunused-private-field false negative with
defaul
whiteio wrote:
I'll update my changes to fix the other tests that are failing this evening,
sorry about that, should have ran the rest of them after making the change.
https://github.com/llvm/llvm-project/pull/116871
___
cfe-commits mailing list
cfe-c
https://github.com/whiteio updated
https://github.com/llvm/llvm-project/pull/116871
>From c69426607d63b3a0cf7d839c82cde55273a5f942 Mon Sep 17 00:00:00 2001
From: Chris White
Date: Tue, 19 Nov 2024 20:06:28 +
Subject: [PATCH 1/2] [Clang] Fix -Wunused-private-field false negative with
defaul
@@ -7535,7 +7535,7 @@ void Sema::CheckExplicitlyDefaultedFunction(Scope *S,
FunctionDecl *FD) {
return;
}
- if (DefKind.isComparison())
+ if (DefKind.isComparison() && isa(FD->getDeclContext()))
UnusedPrivateFields.clear();
whiteio wrote:
Thanks
@@ -20,6 +20,17 @@ class SpaceShipDefaultCompare {
int operator<=>(const SpaceShipDefaultCompare &) const = default;
};
+class UnusedConstPrivateField {
+ public:
+ UnusedConstPrivateField() : unused_(0) {}
+ private:
+ const int unused_; // expected-warning{{private field
https://github.com/whiteio created
https://github.com/llvm/llvm-project/pull/116871
Fix -Wunused-private-field incorrectly suppressing warnings for friend
defaulted comparison operators. The warning should only be suppressed when the
defaulted comparison is a class member function.
Fixes #116
19 matches
Mail list logo
