[PATCH] D97927: [clang-format] Rename case sorting

2021-03-04 Thread Chris Johnson via Phabricator via cfe-commits
PragmaNull accepted this revision. PragmaNull added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97927/new/ https://reviews.llvm.org/D97927 ___ cfe-commits mailing list cfe-commits

[PATCH] D95017: [clang-format] Add case aware include sorting.

2021-03-02 Thread Chris Johnson via Phabricator via cfe-commits
PragmaNull added a comment. In D95017#2595230 , @HazardyKnusperkeks wrote: > > Do you make a change? Otherwise I will do, but that will take some time, > because I'm rather busy. Sorry, I have not; unfortunately I've been rather busy myself and have

[PATCH] D95017: [clang-format] Add case aware include sorting.

2021-02-18 Thread Chris Johnson via Phabricator via cfe-commits
PragmaNull added a comment. In D95017#2572238 , @curdeius wrote: > Do you have an idea for better names? > I see that e.g. MS documentation uses ascending order and case-sensitive > order. I'm okay with the names, it just seems to me that they are revers

[PATCH] D95017: [clang-format] Add case aware include sorting.

2021-02-18 Thread Chris Johnson via Phabricator via cfe-commits
PragmaNull added a comment. I find the naming of the case sensitive options confusing here. When I read "CaseSensitive" I think of the behavior of strcmp() which sorts according to "ASCIIbetical" order. But here "CaseSensitive" throws away case by comparing the result of "Filename.lower()" whic