[clang] [NFC][Clang] Use StringSwitch instead of array for parsing attribute scope (PR #115414)

https://github.com/chinmaydd closed https://github.com/llvm/llvm-project/pull/115414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Use StringSwitch instead of array for parsing attribute scope (PR #115414)

https://github.com/chinmaydd updated https://github.com/llvm/llvm-project/pull/115414 >From ce67d44d55ef488bac9428b4c7b78e37ea8471f6 Mon Sep 17 00:00:00 2001 From: Chinmay Deshpande Date: Thu, 7 Nov 2024 22:05:03 -0500 Subject: [PATCH 1/2] [NFC][Clang] Use StringSwitch instead of array for par

[clang] [NFC][Clang] Use StringSwitch instead of array for parsing attribute scope (PR #115414)

@@ -155,26 +156,23 @@ std::string AttributeCommonInfo::getNormalizedFullName() const { normalizeName(getAttrName(), getScopeName(), getSyntax())); } -// Sorted list of attribute scope names -static constexpr std::pair ScopeList[] = -{{"", AttributeCommonInfo::Scope:

[clang] [NFC][Clang] Use StringSwitch instead of array for parsing attribute scope (PR #115414)

https://github.com/chinmaydd updated https://github.com/llvm/llvm-project/pull/115414 >From ce67d44d55ef488bac9428b4c7b78e37ea8471f6 Mon Sep 17 00:00:00 2001 From: Chinmay Deshpande Date: Thu, 7 Nov 2024 22:05:03 -0500 Subject: [PATCH 1/2] [NFC][Clang] Use StringSwitch instead of array for par

[clang] [NFC][Clang] Use StringSwitch instead of array for parsing attribute scope (PR #115414)

https://github.com/chinmaydd updated https://github.com/llvm/llvm-project/pull/115414 >From ce67d44d55ef488bac9428b4c7b78e37ea8471f6 Mon Sep 17 00:00:00 2001 From: Chinmay Deshpande Date: Thu, 7 Nov 2024 22:05:03 -0500 Subject: [PATCH 1/2] [NFC][Clang] Use StringSwitch instead of array for par

[clang] [NFC][Clang] Use StringSwitch instead of array for parsing attribute scope (PR #115414)

https://github.com/chinmaydd created https://github.com/llvm/llvm-project/pull/115414 None >From ce67d44d55ef488bac9428b4c7b78e37ea8471f6 Mon Sep 17 00:00:00 2001 From: Chinmay Deshpande Date: Thu, 7 Nov 2024 22:05:03 -0500 Subject: [PATCH] [NFC][Clang] Use StringSwitch instead of array for pa

[clang] [Clang] Improve EmitClangAttrSpellingListIndex (PR #114899)

@@ -153,12 +155,37 @@ std::string AttributeCommonInfo::getNormalizedFullName() const { normalizeName(getAttrName(), getScopeName(), getSyntax())); } +// Sorted list of attribute scope names +static constexpr std::pair ScopeList[] = +{{"", AttributeCommonInfo::Scope:

[clang] [Clang] Improve EmitClangAttrSpellingListIndex (PR #114899)

chinmaydd wrote: Fixed by https://github.com/llvm/llvm-project/commit/dd1c99bac4dc1d5ceeadc79dd31fa12f3e615f18 https://github.com/llvm/llvm-project/pull/114899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [Clang] Improve EmitClangAttrSpellingListIndex (PR #114899)

chinmaydd wrote: Thanks @erichkeane and @arsenm ! https://github.com/llvm/llvm-project/pull/114899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Improve EmitClangAttrSpellingListIndex (PR #114899)

https://github.com/chinmaydd closed https://github.com/llvm/llvm-project/pull/114899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Improve EmitClangAttrSpellingListIndex (PR #114899)

https://github.com/chinmaydd updated https://github.com/llvm/llvm-project/pull/114899 >From cf4d70c23b2896483b452622300aa4c8c41c01e5 Mon Sep 17 00:00:00 2001 From: Chinmay Deshpande Date: Fri, 1 Nov 2024 19:49:52 -0400 Subject: [PATCH 1/6] [Clang] Improve EmitClangAttrSpellingListIndex EmitCla

[clang] [Clang] Improve EmitClangAttrSpellingListIndex (PR #114899)

https://github.com/chinmaydd updated https://github.com/llvm/llvm-project/pull/114899 >From cf4d70c23b2896483b452622300aa4c8c41c01e5 Mon Sep 17 00:00:00 2001 From: Chinmay Deshpande Date: Fri, 1 Nov 2024 19:49:52 -0400 Subject: [PATCH 1/5] [Clang] Improve EmitClangAttrSpellingListIndex EmitCla

[clang] [Clang] Improve EmitClangAttrSpellingListIndex (PR #114899)

https://github.com/chinmaydd ready_for_review https://github.com/llvm/llvm-project/pull/114899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Improve EmitClangAttrSpellingListIndex (PR #114899)

https://github.com/chinmaydd updated https://github.com/llvm/llvm-project/pull/114899 >From cf4d70c23b2896483b452622300aa4c8c41c01e5 Mon Sep 17 00:00:00 2001 From: Chinmay Deshpande Date: Fri, 1 Nov 2024 19:49:52 -0400 Subject: [PATCH 1/4] [Clang] Improve EmitClangAttrSpellingListIndex EmitCla

[clang] [NFC] [clang] Use std::string instead of StringRef to reduce stack usage (PR #114285)

https://github.com/chinmaydd closed https://github.com/llvm/llvm-project/pull/114285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [clang] Use std::string instead of StringRef to reduce stack usage (PR #114285)

chinmaydd wrote: Thank you everyone for the review. On my local setup, this function occupies close to 185KB of local stack (MSVC 14.38.33130), which is really wasteful. Like @kparzysz highlighted, we observed a crash in `__chkstk()` which is inserted by MSVC in the prologue when a function r

[clang] [NFC] [clang] Use std::string instead of StringRef to reduce stack usage (PR #114285)

https://github.com/chinmaydd updated https://github.com/llvm/llvm-project/pull/114285 >From e075173eca885ad1283d9ebb76a79b8ec51d7432 Mon Sep 17 00:00:00 2001 From: Chinmay Diwakar Deshpande Date: Wed, 30 Oct 2024 10:28:15 -0700 Subject: [PATCH 1/2] [NFC] [clang] Use std::string instead of Strin