Author: chh
Date: Wed Aug 22 10:13:40 2018
New Revision: 340421
URL: http://llvm.org/viewvc/llvm-project?rev=340421&view=rev
Log:
[Tooling] Allow -flto flags and filter out -Wa, flags
This change fixes the problem in https://bugs.llvm.org/show_bug.cgi?id=38332
by allowing driver::Action::BackendJ
Should we have two versions of `__gcov_flush`?
One version is visible outside a .so file,
we use dlsym to find and call it to dump
profile data of .so files, like Android.
One version is hidden and must be called from another
wrapper function in a .so file. An application that
wants to flush .so
Author: chh
Date: Thu Mar 1 14:26:19 2018
New Revision: 326499
URL: http://llvm.org/viewvc/llvm-project?rev=326499&view=rev
Log:
[Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS
Since LLVM r326341, default EmulatedTLS mode is decided in backend
according to target triple. Any fro
Author: chh
Date: Tue Sep 26 17:58:45 2017
New Revision: 314264
URL: http://llvm.org/viewvc/llvm-project?rev=314264&view=rev
Log:
[clang-format] Adjust space around &/&& of structured bindings
Keep space before or after the &/&& tokens, but not both. For example,
auto [x,y] = a;
auto &[xr, yr
rror,-Wunused-const-variable]
> static constexpr const char *SOCK_CLOEXEC = "SOCK_CLOEXEC";
>
> Please test with LLVM_ENABLE_WERROR=ON before submitting!
>
>
> On Wed, Aug 16, 2017 at 9:59 AM, Chih-Hung Hsieh via cfe-commits
> wrote:
> > Author: chh
> > Da
Author: chh
Date: Wed Aug 16 14:00:06 2017
New Revision: 311040
URL: http://llvm.org/viewvc/llvm-project?rev=311040&view=rev
Log:
[clang-tidy] Remove unused static variable.
Differential Revision: https://reviews.llvm.org/D36761
Modified:
clang-tools-extra/trunk/clang-tidy/android/CloexecSo
Author: chh
Date: Wed Aug 16 12:13:35 2017
New Revision: 311035
URL: http://llvm.org/viewvc/llvm-project?rev=311035&view=rev
Log:
[clang-tidy] Use const char* to compile with VC cl.exe.
Summary:
cl.exe does not accept constexpr char FuncBindingStr[] = ...
Differential Revision: https://reviews.l
Author: chh
Date: Wed Aug 16 11:02:49 2017
New Revision: 311029
URL: http://llvm.org/viewvc/llvm-project?rev=311029&view=rev
Log:
[clang-tidy] Add a close-on-exec check on epoll_create() in Android module.
Summary:
epoll_create() is better to be replaced by epoll_create1() with EPOLL_CLOEXEC
flag
Author: chh
Date: Wed Aug 16 10:53:12 2017
New Revision: 311028
URL: http://llvm.org/viewvc/llvm-project?rev=311028&view=rev
Log:
[clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.
Summary:
epoll_create1() is better to set EPOLL_CLOEXEC flag to avoid file descriptor
lea
Author: chh
Date: Wed Aug 16 10:46:18 2017
New Revision: 311027
URL: http://llvm.org/viewvc/llvm-project?rev=311027&view=rev
Log:
[clang-tidy] Add a close-on-exec check on accept4() in Android module.
Summary:
accept4() is better to set SOCK_CLOEXEC flag to avoid file descriptor leakage.
Differe
Author: chh
Date: Wed Aug 16 10:18:16 2017
New Revision: 311024
URL: http://llvm.org/viewvc/llvm-project?rev=311024&view=rev
Log:
[clang-tidy] Add a close-on-exec check on accept() in Android module.
Summary:
accept() is better to be replaced by accept4() with SOCK_CLOEXEC
flag to avoid file desc
Author: chh
Date: Wed Aug 16 09:59:26 2017
New Revision: 311020
URL: http://llvm.org/viewvc/llvm-project?rev=311020&view=rev
Log:
[clang-tidy] Use CloexecCheck as base class.
Summary:
Simplify registerMatchers and check functions in CloexecCreatCheck,
CloexecSocketCheck, CloexecFopenCheck, and Cl
Author: chh
Date: Mon Aug 14 10:45:48 2017
New Revision: 310863
URL: http://llvm.org/viewvc/llvm-project?rev=310863&view=rev
Log:
[clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.
Summary:
inotify_init1() is better to set IN_CLOEXEC flag to avoid file descriptor
leakag
Author: chh
Date: Mon Aug 14 10:25:41 2017
New Revision: 310861
URL: http://llvm.org/viewvc/llvm-project?rev=310861&view=rev
Log:
[clang-tidy] Add a close-on-exec check on inotify_init() in Android module.
Summary:
inotify_init() is better to be replaced by inotify_init1() with IN_CLOEXEC flag
t
Author: chh
Date: Mon Aug 14 10:04:16 2017
New Revision: 310858
URL: http://llvm.org/viewvc/llvm-project?rev=310858&view=rev
Log:
[clang-tidy] Add a close-on-exec check on dup() in Android module.
Summary:
dup() is better to be replaced by fcntl() to avoid file descriptor leakage.
Differential R
Author: chh
Date: Wed Jul 12 09:27:00 2017
New Revision: 307810
URL: http://llvm.org/viewvc/llvm-project?rev=307810&view=rev
Log:
[clang-tidy] add regression test to performance-unnecessary-value-param
This test shows the problem in https://bugs.llvm.org/show_bug.cgi?id=33734
Differential Revisi
Author: chh
Date: Wed Jul 12 09:25:40 2017
New Revision: 307809
URL: http://llvm.org/viewvc/llvm-project?rev=307809&view=rev
Log:
[clang] buildFixItInsertionLine should use Hints of the same FID and LineNo
Fix bug https://bugs.llvm.org/show_bug.cgi?id=33734
Differential Revision: https://reviews
Author: chh
Date: Tue May 23 11:19:04 2017
New Revision: 303645
URL: http://llvm.org/viewvc/llvm-project?rev=303645&view=rev
Log:
[clang-tidy] Do not dereference a null BaseType
Check BaseType before dereference.
Simplified test case is derived from Android Open Source code.
Differential Revisio
Author: chh
Date: Thu Apr 6 15:19:26 2017
New Revision: 299700
URL: http://llvm.org/viewvc/llvm-project?rev=299700&view=rev
Log:
[clang-tidy] Reuse FileID in getLocation
One FileID per warning will increase and overflow NextLocalOffset
when input file is large with many warnings.
Reusing FileID
Author: chh
Date: Thu Apr 6 13:36:50 2017
New Revision: 299681
URL: http://llvm.org/viewvc/llvm-project?rev=299681&view=rev
Log:
[Basic] getColumnNumber returns location of CR+LF on Windows
When fixing a Clang-Tidy bug in D31406,
reuse of FileID enabled the missing highlightRange function.
Asser
Author: chh
Date: Thu Mar 30 20:11:11 2017
New Revision: 299146
URL: http://llvm.org/viewvc/llvm-project?rev=299146&view=rev
Log:
[clang-tidy] Revert D31406 (Reuse FileID in getLocation)
Somehow the change failed test clang-tidy/llvm-include-order.cpp
on Windows platform.
Differential Revision:
ools\\extra\\
> test\\clang-tidy\\Output\\llvm-include-order.cpp.tmp.cpp', '-fix',
> '--checks=-*,llvm-include-order', '--', '-isystem',
> 'C:\\Buildbot\\Slave\\llvm-clang-lld-x86_64-scei-ps4-
> windows10pro-fast\\llvm.src\\tools\\clang\\t
Author: chh
Date: Thu Mar 30 17:09:17 2017
New Revision: 299119
URL: http://llvm.org/viewvc/llvm-project?rev=299119&view=rev
Log:
[clang-tidy] Reuse FileID in getLocation
One FileID per warning will increase and overflow NextLocalOffset
when input file is large with many warnings.
Reusing FileID
Ismail,
I saw that android-ndk-standalone.cpp has already -stdlib=libstdc++.
Could you tell me or just go ahead and make the necessary change?
Thanks.
On Thu, Jun 2, 2016 at 9:52 AM, Ismail Donmez wrote:
> Hi,
>
> On Wed, Jun 1, 2016 at 11:48 PM, Chih-Hung Hsieh via cfe-commits
Author: chh
Date: Wed Jun 1 17:53:59 2016
New Revision: 271438
URL: http://llvm.org/viewvc/llvm-project?rev=271438&view=rev
Log:
[driver][arm] change regular expression to work on Windows
Differential Revision: http://reviews.llvm.org/D20600
Modified:
cfe/trunk/test/Driver/android-ndk-stand
Author: chh
Date: Wed Jun 1 15:48:46 2016
New Revision: 271427
URL: http://llvm.org/viewvc/llvm-project?rev=271427&view=rev
Log:
[driver][arm] add armv7 and thumb include and lib paths
Add a new test android-ndk-standalone.cpp
with new Android NDK release tree structure.
Detect armv7 sub archite
chh closed this revision.
chh added a comment.
Was submitted in r267832 | chh | 2016-04-27 18:09:09 -0700 (Wed, 27 Apr 2016)
http://reviews.llvm.org/D19393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: chh
Date: Wed Apr 27 20:09:09 2016
New Revision: 267832
URL: http://llvm.org/viewvc/llvm-project?rev=267832&view=rev
Log:
[analyzer] Move Checkers.inc to clang/include/...
Simplify sharing of Checkers.inc with other files like ClangTidy.cpp.
Differential Revision: http://reviews.llvm.org
chh marked 2 inline comments as done.
chh added a comment.
I used "svn mv" to move the file and "svn diff --show-copies-as-adds" to
generate the diff.
If I didn't use "--show-copies-as-adds", the new file was not included/shown by
phabricator at all.
Please let me know if there is better way to
chh updated this revision to Diff 54758.
chh added a comment.
Also move Checkers.td to clang/include/.../Checkers.
http://reviews.llvm.org/D19393
Files:
include/clang/CMakeLists.txt
include/clang/StaticAnalyzer/Checkers/CMakeLists.txt
include/clang/StaticAnalyzer/Checkers/Checkers.td
li
chh added a comment.
See dependent change of ClangTidy.cpp in http://reviews.llvm.org/D19393.
http://reviews.llvm.org/D19393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh added a comment.
This change depends on http://reviews.llvm.org/D19393.
http://reviews.llvm.org/D19249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh updated this revision to Diff 54587.
http://reviews.llvm.org/D19249
Files:
clang-tidy/ClangTidy.cpp
Index: clang-tidy/ClangTidy.cpp
===
--- clang-tidy/ClangTidy.cpp
+++ clang-tidy/ClangTidy.cpp
@@ -58,7 +58,7 @@
#define GET_C
chh created this revision.
chh added reviewers: srhines, alexfh.
chh added a subscriber: cfe-commits.
Herald added subscribers: danalbert, tberghammer.
https://llvm.org/bugs/show_bug.cgi?id=27355
To compile with other binary output directory structures in build systems like
Android.
Allow clang-t
chh created this revision.
chh added reviewers: srhines, alexfh.
chh added a subscriber: cfe-commits.
Herald added subscribers: danalbert, tberghammer.
https://llvm.org/bugs/show_bug.cgi?id=27355
To compile with other binary output directory structures in build systems like
Android.
http://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264164: [analyzer] Fix typo s/initalize/initialize/
(authored by chh).
Changed prior to commit:
http://reviews.llvm.org/D18363?vs=51307&id=51429#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1836
Author: chh
Date: Wed Mar 23 11:14:12 2016
New Revision: 264164
URL: http://llvm.org/viewvc/llvm-project?rev=264164&view=rev
Log:
[analyzer] Fix typo s/initalize/initialize/
Differential Revision: http://reviews.llvm.org/D18363
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CallAndMessageC
Glad to see that emutls is useful for Cygwin too.
The diff in rL257984 do not look like depending on rL257718.
It might work with my earlier implementation of emutls, before rL257718.
Anyway, I did not test on Cygwin, and don't care if rL257984 is in 3.8 or
not.
Thanks.
On Tue, Jan 19, 2016 at 4:
chh added a comment.
If there were only two different types,
we should have mangled name 'd' for double and 'e' for long double,
even if their implementations are the same.
The problem came when g++ has __float80 and __float128 types,
and long double could be implemented as __float80 or __float12
chh added a comment.
Please rebase the change to r244502 or newer, to run with -Asserts builds.
Thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D11921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
I submitted a new patch into r244502.
Please let me know if there is any other error.
Thanks.
On Mon, Aug 10, 2015 at 12:46 PM, David Blaikie wrote:
>
>
> On Mon, Aug 10, 2015 at 10:33 AM, Chih-Hung Hsieh via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> A
Author: chh
Date: Mon Aug 10 15:58:54 2015
New Revision: 244502
URL: http://llvm.org/viewvc/llvm-project?rev=244502&view=rev
Log:
Fix test case to work with -Asserts builds.
When clang is built with -DLLVM_ENABLE_ASSERTIONS=Off,
it does not create names for IR values.
Differential Revision: http
Author: chh
Date: Mon Aug 10 12:33:31 2015
New Revision: 244468
URL: http://llvm.org/viewvc/llvm-project?rev=244468&view=rev
Log:
Correct x86_64 fp128 calling convention
These changes are for Android x86_64 targets to be compatible
with current Android g++ and conform to AMD64 ABI.
https://llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244468: Correct x86_64 fp128 calling convention (authored by
chh).
Changed prior to commit:
http://reviews.llvm.org/D11437?vs=31457&id=31687#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11437
F
chh added a comment.
Reid, thanks a lot for fixing my hacks!
I tried your new diff 31457 and it worked for Android libm and all my other
tests.
I am still waiting for some review of the back end changes in
http://reviews.llvm.org/D11438.
This patch can be submitted now or later with http://revi
45 matches
Mail list logo
