tigerleapgorge added a comment.
In https://reviews.llvm.org/D30430#688146, @rjmccall wrote:
> The C++98 behavior here is not really vital to test precisely; it's just
> minor differences in what gets instantiated and when.
Hi John, my main concern with CHECK-NOT appearing between CHECK lines i
tigerleapgorge updated this revision to Diff 90078.
tigerleapgorge added a comment.
Updated patch.
Test only runs in C++11.
Added comments to explain CHECK-DAG and CHECK2-NOT.
https://reviews.llvm.org/D30430
Files:
test/CodeGenCXX/template-instantiation.cpp
Index: test/CodeGenCXX/template-
tigerleapgorge created this revision.
This test failure is caused by difference in IR ordering when compiling at
C++98 vs C++11
Because there was a CHECK-NOT between the two CHECKs, just changing the CHECKs
to CHECK-DAG would not work.
So to make FileCheck more flexible.
I have changed the CHEC
tigerleapgorge closed this revision.
tigerleapgorge added a comment.
warn-thread-safety-parsing.cpp has been commited in
https://reviews.llvm.org/rL296193.
The following FIXME has been added to track this bug.
//FIXME: Bug 32066 - Error should be emitted irrespective of C++ dialect
https://rev
tigerleapgorge marked 2 inline comments as done.
tigerleapgorge added inline comments.
Comment at: test/SemaCXX/PR9572.cpp:34
+// expected-error@-2 {{non-deleted function '~Bar' cannot override a deleted
function}}
+// expected-note@-3 {{while declaring the implicit destructor f
tigerleapgorge updated this revision to Diff 89736.
tigerleapgorge added a comment.
Updated patch in accordance to Richard Smith's comments.
https://reviews.llvm.org/D21626
Files:
test/Modules/Inputs/merge-using-decls/b.h
test/Modules/merge-using-decls.cpp
test/SemaCXX/PR9572.cpp
test/S
tigerleapgorge abandoned this revision.
tigerleapgorge added a comment.
https://reviews.llvm.org/D20710 is a superset of this patch.
https://reviews.llvm.org/D20710 has been committed in
https://reviews.llvm.org/rL296184.
No need for this patch.
https://reviews.llvm.org/D29972
__
tigerleapgorge accepted this revision.
tigerleapgorge added a comment.
This revision is now accepted and ready to land.
Of the 3 tests.
format-strings.cpp and printf-cstr.cpp have been commited in r294979
For warn-thread-safety-parsing.cpp, bug 32066 has been filed to track the lack
of thread saf
tigerleapgorge added a comment.
@rjmccall
Hi John, I've made the changes to volatile.cpp.
I take it this patch is good for commit?
https://reviews.llvm.org/D24812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
tigerleapgorge updated this revision to Diff 88617.
tigerleapgorge added a comment.
Changed "CHECK11" to "CHECK11-NEXT".
https://reviews.llvm.org/D24812
Files:
test/CodeGenCXX/mangle-unnamed.cpp
test/CodeGenCXX/static-init.cpp
test/CodeGenCXX/volatile-1.cpp
test/CodeGenCXX/volatile.cpp
tigerleapgorge created this revision.
Herald added a subscriber: mehdi_amini.
I am continuing to make Lit tests C++11 compatible.
This patch contains 2 tests previously in https://reviews.llvm.org/D20710.
In both tests, I have made the base class destructors “protected” so they are
accessible to
tigerleapgorge reclaimed this revision.
tigerleapgorge added a comment.
@rjmccall - Hi John, I have reopened this patch.
https://reviews.llvm.org/D29739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
tigerleapgorge updated this revision to Diff 88232.
tigerleapgorge edited the summary of this revision.
tigerleapgorge added a comment.
Remove 2 tests reviewed in https://reviews.llvm.org/D29685
https://reviews.llvm.org/D21626
Files:
test/Modules/Inputs/merge-using-decls/a.h
test/Modules/In
tigerleapgorge added a comment.
@aaron.ballman Thank you for the code review. I take it I can commit the first
2 tests?
@delesley Thank you for the analysis. Should I open a bugzilla to track this
issue?
https://reviews.llvm.org/D29685
___
cfe-co
tigerleapgorge updated this revision to Diff 88224.
tigerleapgorge edited the summary of this revision.
tigerleapgorge added a comment.
Remove another 3 tests reviewed in https://reviews.llvm.org/D29859
https://reviews.llvm.org/D24812
Files:
test/CodeGenCXX/mangle-unnamed.cpp
test/CodeGenCX
tigerleapgorge created this revision.
I am continuing to make Lit tests C++11 compatible.
There are 3 tests in this patch (previously in https://reviews.llvm.org/D24812).
All 3 tests relate to C++11 destructors being nonthrowing by default.
CodeGenCXX/linetable-cleanup.cpp
C::~C() has an extra
tigerleapgorge added a comment.
Hi John,
Here is the most recent discussion I can find on cfe-dev.
“I'm guessing that Objective-C/C++ is kind of passe, so nobody is really
interested in modernizing it”
http://lists.llvm.org/pipermail/cfe-dev/2016-December/051844.html
As far as I am aware, there
tigerleapgorge abandoned this revision.
tigerleapgorge added a comment.
These tests were failing because I accidentally changed the Objective-C++.
Abandoning this patch.
https://reviews.llvm.org/D29739
___
cfe-commits mailing list
cfe-commits@lists.
tigerleapgorge created this revision.
I am continuing to make our Lit tests C++11 compatible.
This patch defaults five Objective-C++ tests to run under -std=gnu++98
This patch is essentially a continuation of Bug 24344
https://llvm.org/bugs/show_bug.cgi?id=24344
Fix r289167 resolved all tests in
tigerleapgorge updated this revision to Diff 87711.
tigerleapgorge edited the summary of this revision.
tigerleapgorge added a comment.
Remove 2 OpenMP tests reviewed via https://reviews.llvm.org/D29725
https://reviews.llvm.org/D21626
Files:
test/Modules/Inputs/merge-using-decls/a.h
test/Mo
tigerleapgorge created this revision.
I am continuing to make out Lit tests C++11 compatible.
There are two tests in this patch.
Both tests verify parse errors with ill formed OpenMP expressions.
test/OpenMP/declare_reduction_messages.cpp
In C++11, an opening square bracket is the start of a l
tigerleapgorge created this revision.
I am continuing to make Lit tests C++11 compatible.
This patch contains 3 tests, previously in review
https://reviews.llvm.org/D21626.
First two tests involve printf format attributes.
The third test involve thread safety attribute.
Here are the descriptions
tigerleapgorge updated this revision to Diff 87312.
tigerleapgorge added a comment.
Remove 2 tests reviewed under https://reviews.llvm.org/D29520.
https://reviews.llvm.org/D21626
Files:
test/Modules/Inputs/merge-using-decls/a.h
test/Modules/Inputs/merge-using-decls/b.h
test/Modules/merge-
tigerleapgorge updated this revision to Diff 87309.
tigerleapgorge added a comment.
2 tests have been reviewed in https://reviews.llvm.org/D29520
They are: implicit-virtual-member-functions.cpp and virtual-member-functions.cpp
Remove these from this patch.
https://reviews.llvm.org/D20710
Files:
tigerleapgorge created this revision.
I am continuing to make Lit tests C++11 compatible.
This patch contains 4 tests, previously in review
https://reviews.llvm.org/D20710 and https://reviews.llvm.org/D21626.
test/SemaCXX/MicrosoftExtensions.cpp
This test checks for Microsoft extensions.
Po
tigerleapgorge updated this revision to Diff 86994.
tigerleapgorge added a comment.
Update again, remove 4 OpenMP tests here because they have been checked in
https://reviews.llvm.org/rL294025 under review https://reviews.llvm.org/D29480.
13 tests left.
https://reviews.llvm.org/D20710
Files:
tigerleapgorge created this revision.
I am continuing to make Lit tests C++11 compatible.
This patch is a subset of the previous https://reviews.llvm.org/D20710
This patch contains 4 tests, the changes are nearly identical.
C++11 introduced constexpr, hence the change in diagnostics.
C++11 added
tigerleapgorge updated this revision to Diff 86923.
tigerleapgorge added a comment.
Revise again,
https://reviews.llvm.org/D28425 fixed 7 tests.
r290229 fixed 1 test.
Down to 8 tests.
https://reviews.llvm.org/D24812
Files:
test/CodeGenCXX/linetable-cleanup.cpp
test/CodeGenCXX/lpad-linetab
tigerleapgorge created this revision.
tigerleapgorge added reviewers: rjmccall, rsmith.
tigerleapgorge added a subscriber: cfe-commits.
Hi everyone,
I am Charles Li at Sony Playstation.
I am refactoring my existing C++11 compatibility patches to make them easier to
review.
This patch is a subset
tigerleapgorge updated the summary for this revision.
tigerleapgorge updated this revision to Diff 81987.
tigerleapgorge added a comment.
Update Lit patch #11 to match latest Clang behavior
2 minor changes in this update
1. Back out test/CodeGenCXX/mangle-unnamed.cpp because it has already been
tigerleapgorge updated this revision to Diff 81817.
tigerleapgorge added a comment.
Previous update contain typos in the RUN lines of
test/SemaCXX/virtual-base-used.cpp
This has been corrected in this latest revision.
https://reviews.llvm.org/D21626
Files:
test/Modules/Inputs/merge-using-dec
tigerleapgorge updated this revision to Diff 81810.
tigerleapgorge added a comment.
Update patch to match latest Clang C++11 diagnostics.
2 tests are changed.
test/SemaCXX/PR9572.cpp
Expect the following additional Note following existing Error.
destructor of 'Foo' is implicitly deleted b
tigerleapgorge updated this revision to Diff 81784.
tigerleapgorge added a comment.
Forgot to include all context inside the previous revision.
Previous patch: svn diff
This patch:svn diff --diff-cmd=diff -x -U99
https://reviews.llvm.org/D20710
Files:
test/CodeGenCXX/debug-info-u
tigerleapgorge updated this revision to Diff 81776.
tigerleapgorge added a comment.
Lit C++11 compatibility patch #9
Update patch again to expect for latest Trunk C++11 diagnostics.
Tests in CXX directory are already passing in C++11, so they are removed from
this patch.
Of the remaining tests,
34 matches
Mail list logo
