[PATCH] D155408: [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45ff63ba6112: [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min (authored by porglezomp). Repository: rG LLVM Github Monorepo

[PATCH] D155408: [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min

porglezomp updated this revision to Diff 541157. porglezomp added a comment. Update to check the target OSes more precisely Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155408/new/ https://reviews.llvm.org/D155408 Files: clang/lib/Driver/ToolCh

[PATCH] D155407: [Driver] Warn about all instances -mios-version-min not just the last

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7ad7d147b9c: [Driver] Warn about all instances -mios-version-min not just the last (authored by porglezomp). Repository: rG LLVM Github Monorepo

[PATCH] D155408: [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min

porglezomp created this revision. porglezomp added reviewers: arphaman, t.p.northover, MaskRay, ahatanak. Herald added a subscriber: kristof.beyls. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some

[PATCH] D155407: [Driver] Warn about all instances -mios-version-min not just the last

porglezomp created this revision. porglezomp added reviewers: arphaman, t.p.northover, MaskRay, ahatanak. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow-up to D155123

[PATCH] D151532: [test] Test ext_vector_type operators with implicit conversions

porglezomp updated this revision to Diff 525974. porglezomp added a comment. Add significantly more variations in this test case. I discovered multiple inconsistencies while expanding this list out. Filed an issue on GitHub here: https://github.com/llvm/llvm-project/issues/62949 Repository: rG

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp added a comment. Confirming your sense that those loops look a bit suspicious, I've found that this makes some implicit conversions ambiguous. Put a test case up for that at D151532 , I think I understand what those loops should be changed to instead,

[PATCH] D151532: [test] Test ext_vector_type operators with implicit conversions

porglezomp created this revision. porglezomp added reviewers: aaron.ballman, fhahn. Herald added a subscriber: StephenFan. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An extra test for implicit co

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9041-9044 + // (allowing splatting the scalar to a vector). + for (unsigned Candidate = 0; Candidate < 2; ++Candidate) { +for (QualType Vec1Ty : CandidateTypes[Candidate].vector_types(

[PATCH] D151059: [test] Add C++ ext_vector_type tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG590eb76ba3cd: [test] Add C++ ext_vector_type tests (authored by porglezomp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151059/new/ https://reviews.llvm.

[PATCH] D151061: [test] Add ext_vector_type tests for C

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b689679e1e: [test] Add more ext_vector_type tests for C (authored by porglezomp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151061/new/ https://review

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp updated this revision to Diff 524432. porglezomp added a comment. Rebasing onto modified tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151060/new/ https://reviews.llvm.org/D151060 Files: clang/lib/Sema/SemaOverload.cpp clang/t

[PATCH] D151059: [test] Add C++ ext_vector_type tests

porglezomp updated this revision to Diff 524429. porglezomp added a comment. Address review comments. File GitHub issues and reference them with the FIXMEs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151059/new/ https://reviews.llvm.org/D151059

[PATCH] D151061: [test] Add ext_vector_type tests for C

porglezomp updated this revision to Diff 524405. porglezomp added a comment. Address the comment suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151061/new/ https://reviews.llvm.org/D151061 Files: clang/test/Sema/ext_vector_ops.c cla

[PATCH] D151059: [test] Add C++ ext_vector_type tests

porglezomp added a comment. See also: C versions of these test cases: D151061 I think the C versions behave correctly and that C++ should match that behavior. Interested in feedback from anyone working with ext_vector_types. Repository: rG LLVM Github Monor

[PATCH] D151061: [test] Add ext_vector_type tests for C

porglezomp added a comment. See also: very similar baseline tests for C++: D151059 I'm interested in any feedback about the correct semantics for this. I started writing these tests while investigating the behavior of vector vs scalar operations in C++ for D15

[PATCH] D151061: [test] Add ext_vector_type tests for C

porglezomp created this revision. porglezomp added reviewers: aaron.ballman, fhahn. Herald added a subscriber: StephenFan. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Test that all vector-vs-scala

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp created this revision. porglezomp added reviewers: aaron.ballman, fhahn. Herald added a subscriber: StephenFan. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The bit-shifting operator bui

[PATCH] D151059: [test] Add C++ ext_vector_type tests

porglezomp created this revision. porglezomp added reviewers: aaron.ballman, fhahn. Herald added a subscriber: StephenFan. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add initial tests for the beh

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e2709479636: [clang] Include clang config.h in LangStandards.cpp (authored by porglezomp). Changed prior to commit: https://reviews.llvm.org/D124974?vs=429275&id=429416#toc Repository: rG LLVM Githu

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp updated this revision to Diff 429275. porglezomp added a comment. I haven't used arc in a little while and am having trouble sorry for the emails Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp updated this revision to Diff 429274. porglezomp added a comment. Arcanist accidentally threw away the first commit in the sequence... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974 Files: c

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp updated this revision to Diff 429273. porglezomp added a comment. Herald added a subscriber: mgorny. Add changes suggested by Duncan to make CLANG_DEFAULT_STD_C more misuse-resistant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/n

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp added a comment. That looks good to me. I'm testing it out locally to make sure it still works right and also catches the issue, and will plan put up an updated patch in the morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp added a comment. Ah, so it'd be a test that passes pretty trivially on any bot that doesn't have a custom version of `CLANG_DEFAULT_STD_C` and `CLANG_DEFAULT_STD_CXX` like the default config, but could get caught by any other bots that do set it? What's the best way to get the compil

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp added a comment. Unless anyone has an idea about how to test this, I'm going to commit this without adding a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974 _

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp added a comment. I would be interested in adding some kind of test for this, but am not sure how. I think the robust general-purpose check here would be to ensure that no file is referring to symbols defined by the various `config.h` etc. files without including those files, but am n

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp created this revision. porglezomp added reviewers: hokein, sammccall, dexonsmith. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is necessary in order to pick up the default C/C++ sta