[PATCH] D149650: Give NullabilityKind a printing operator<

cmtice added a comment. This is breaking some of our tests. I will give the author a reproducible test case. I am going to revert this while waiting for a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149650/new/ https://reviews.llvm.org/D149

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

cmtice added a comment. Just a heads up: This commit is causing our bootstrap build to fail (your new openmp-system-arch.c test is failing in our stage1 compiler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141105/new/ https://reviews.llvm.org/

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

cmtice added a comment. I did some testing and verified that this commit is causing some of the Sanitizer issues we are seeing. Is there any chance of a revert? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 _

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

cmtice added a comment. When building/running third_party/llvm/llvm-project/clang/test/OpenMP/atomic_messages.c and third_party/llvm/llvm-project/clang/test/OpenMP/atomic_ast_print.cpp, we get use-of-uninitialized-variable error messages: SUMMARY: MemorySanitizer: use-of-uninitialized-value t

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

cmtice added a comment. This commit is causing some of our builds to fail with these errors: clang/lib/Sema/SemaOpenMP.cpp:11372:9: error: unused variable 'D' [-Werror,-Wunused-variable] Expr *D = nullptr; ^ clang/lib/Sema/SemaOpenMP.cpp:11373:9: error: unused variable 'CE' [-Werror

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

cmtice added a comment. This change introduces a circular dependency: BitcodeWriters now depends on TransformUtils, but TransformUtils also depends on BitcodeWriters. This appears to be a layering violation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 228250. cmtice added a comment. Fix small typo in comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/D

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 228144. cmtice added a comment. Remove quotes from -NOT tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/li

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 228130. cmtice added a comment. Fix NODEBUGINFO-NOT test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Dri

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 228115. cmtice added a comment. Remove period from help text. Fix tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 227977. cmtice added a comment. Rename flag to -fdebug-default-version; add help text, mentioning DWARF. Update tests to use -### and add assembler tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 File

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice marked an inline comment as done. cmtice added a comment. Yes, I will change the flag name back to debug-default-version, and add help text mentioning dwarf. I'm in the process of trying to re-do the test cases as required (I'm a bit new to this so it's taking me a bit to figure this out

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 227954. cmtice added a comment. Make second call to ParseDwarfDefaultVersion unconditional (to match the first and avoid errors with -Werror). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/i

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice added a comment. For the record, I double-checked and if we use the flag and don't check for it (i.e. if we move the parsing inside the EmitDwarf is True block) then -Werror does indeed complain about an unused command line argument. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice added a comment. dblaikie: The code, as written, parses the dwarf default version flag, whether or not DWARFVersion is 0, i.e. whether or not a -gdwarf-N flag was passed. It only USES the value if there's no overriding value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice added a comment. Ok, I think the upload was correct this time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 227942. cmtice added a comment. re-try upload again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/T

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice added a comment. Hmmm...I'm having upload issues. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3250 // -gline-directives-only supported only for the DWARF debug info. if (DWARFVersion == 0 && DebugInfoKind == codegenoptions::DebugDirectivesOnly) DebugInf

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 227940. cmtice added a comment. Try uploading correct diff file? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 227910. cmtice marked 9 inline comments as done. cmtice added a comment. Made requested changes: - renamed option to be dwarf-specific - fixed spelling & blank line issues - only set version if emit-dwarf is true - move test to Driver directory I *think* I go

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 22. cmtice added a comment. Made requested formatting changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clan

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice marked 3 inline comments as done. cmtice added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3246-3247 DWARFVersion = ExplicitVersion; } + else if (DefaultDWARFVersion != 0) +DWARFVersion = DefaultDWARFVersion; dblaiki

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice created this revision. cmtice added a reviewer: dblaikie. Herald added subscribers: cfe-commits, fedor.sergeev, aprantl. Herald added a project: clang. Want to decouple setting the DWARF version from enabling/disabling generation of debug info. This adds a new flag '-fdebug-default-versi

[PATCH] D52323: Add necessary support for storing code-model to module IR.

cmtice updated this revision to Diff 166492. cmtice edited the summary of this revision. cmtice added a comment. Move include statement from CodeGenModule.h to CodeGenModule.cpp Remove incorrect "default" case statement. Add test for "tiny" code model. https://reviews.llvm.org/D52323 Files:

[PATCH] D52323: Add necessary support for storing code-model to module IR.

cmtice marked an inline comment as done. cmtice added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:569 + .Default(~0u); +if ((CM != ~0u) && (CM != ~1u)) { + llvm::CodeModel::Model codeModel = static_cast(CM); tejohnson wro

[PATCH] D52323: Add necessary support for storing code-model to module IR.

cmtice created this revision. cmtice added reviewers: tejohnson, pcc. Herald added subscribers: cfe-commits, dexonsmith, mehdi_amini. Currently the code-model does not get saved in the module IR, so if a code model is specified when compiling with LTO, it gets lost and is not propagated properly

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice updated this revision to Diff 145540. cmtice added a comment. Make cfi_blacklist.txt be an empty file. https://reviews.llvm.org/D46403 Files: lib/Driver/SanitizerArgs.cpp test/Driver/Inputs/resource_dir_with_cfi_blacklist/share/cfi_blacklist.txt test/Driver/fsanitize-blacklist.c

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice updated this revision to Diff 145537. cmtice added a comment. Make -resource-dir point to correct directory, in test case; move cfi_blacklist.txt file to 'share' subdirectory in test resource dir. https://reviews.llvm.org/D46403 Files: lib/Driver/SanitizerArgs.cpp test/Driver/Inputs

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice added a comment. I'm not sure if I have commit access or not; Peter was working with me on trying to commit the change. https://reviews.llvm.org/D46403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice updated this revision to Diff 145524. cmtice added a comment. Fix test failure that my previous changes caused. https://reviews.llvm.org/D46403 Files: lib/Driver/SanitizerArgs.cpp test/Driver/Inputs/resource_dir_with_cfi_blacklist/cfi_blacklist.txt test/Driver/fsanitize-blacklist.c

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice added a comment. vsk: Are you asking me to put together a cfi blacklist to ship in the resource directory in the default install as part of this code review? Or is that something you want to see in a different code reivew? https://reviews.llvm.org/D46403 ___

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice updated this revision to Diff 145266. cmtice added a comment. Added comment to change in source code. https://reviews.llvm.org/D46403 Files: lib/Driver/SanitizerArgs.cpp test/Driver/fsanitize-blacklist.c Index: test/Driver/fsanitize-blacklist.c =

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice updated this revision to Diff 145243. cmtice added a comment. Updated the error to only occur for CFI blacklist, and added test case. https://reviews.llvm.org/D46403 Files: lib/Driver/SanitizerArgs.cpp test/Driver/fsanitize-blacklist.c Index: test/Driver/fsanitize-blacklist.c =

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice added a comment. Ok, I'll work on making this CFI-specific and adding a test case. https://reviews.llvm.org/D46403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice updated this revision to Diff 145073. cmtice added a comment. Tried to upload the diff from the correct location. https://reviews.llvm.org/D46403 Files: lib/Driver/SanitizerArgs.cpp Index: lib/Driver/SanitizerArgs.cpp ==

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice created this revision. cmtice added a reviewer: pcc. Herald added a subscriber: cfe-commits. Currently LLVM CFI tries to use an implicit blacklist file, currently in /usr/lib64/clang//share. If the file is not there, LLVM happily continues, which causes CFI to add checks to files/functio