[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

carlo.bertolli added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7791 +OpenMPBindClauseKind bindParam = C->getBindKind(); +switch (bindParam) { +case OMPC_BIND_parallel: { carlo.bertolli wrote: > koops wrote: > > carlo.bertolli wro

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

carlo.bertolli added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7791 +OpenMPBindClauseKind bindParam = C->getBindKind(); +switch (bindParam) { +case OMPC_BIND_parallel: { koops wrote: > carlo.bertolli wrote: > > What if you have s

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

carlo.bertolli added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7791 +OpenMPBindClauseKind bindParam = C->getBindKind(); +switch (bindParam) { +case OMPC_BIND_parallel: { What if you have something like this: void foo(..) { #pr

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

carlo.bertolli added a comment. LGTM but @ABataev should review/approve this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138614/new/ https://reviews.llvm.org/D138614 ___ cfe-commits mailing list cfe-co

[PATCH] D132074: [OpenMP] Add option to assert no nested OpenMP parallelism on the GPU

carlo.bertolli accepted this revision. carlo.bertolli added a comment. This revision is now accepted and ready to land. Thanks for explaining. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132074/new/ https://reviews.llvm.org/D132074 ___

[PATCH] D132074: [OpenMP] Add option to assert no nested OpenMP parallelism on the GPU

carlo.bertolli added a comment. This looks good, but what happens when the user accidentally adds a nested parallel when this option is turned on? Do we get serial (correct) execution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132074/new/ http

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

carlo.bertolli added a comment. This is already a lot of code with parse+sema. I wonder if we should split the patch into two, i.e. 1. parse+sema; 2. code gen? @ABataev ? It should simplify maintenance of the patch and allow time to extend the OpenMP IR builder. Repository: rG LLVM Github Mo

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

carlo.bertolli added a comment. In D102449#2977711 , @tianshilei1992 wrote: > Another thing is how we deal with a corner case. Say the OpenMP code is > written in the following way: > > #pragma omp atomic compare > x = e < x ? e : x; > > That's ho

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

carlo.bertolli added a comment. Thanks for uploading this. I tried it locally and it is missing proper parsing +sema of the cond-expr-stmt and cond-update-stmt as indicate in the openmp 5.1 spec's. I am sure you are aware of this and this is still WIP. Do you plan to add support for that? The r

[PATCH] D43852: [OpenMP] Extend NVPTX SPMD implementation of combined constructs

carlo.bertolli created this revision. carlo.bertolli added a reviewer: ABataev. Herald added subscribers: guansong, jholewinski. This patch extends the SPMD implementation to all target constructs and guards this implementation under a new flag. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D43513: [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd'

carlo.bertolli updated this revision to Diff 135429. carlo.bertolli added a comment. [OpenMP] Add regression test: this verifies that only one call to the runtime for reduction is done in a combined construct with distribute, without simd, and with at least one pragma accepting reduction as a cl

[PATCH] D43513: [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd'

carlo.bertolli created this revision. carlo.bertolli added a reviewer: ABataev. Herald added a subscriber: guansong. This is a bug fix that removes the emission of reduction support for pragma 'distribute' when found alone or in combinations without simd. Pragma 'distribute' does not have a reduc

[PATCH] D41709: [OpenMP] Initial implementation of code generation for pragma 'target teams distribute parallel for' on host

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 321759. Repository: rC Clang https://reviews.llvm.org/D41709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D40795: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for simd' on host

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 319696. Repository: rC Clang https://reviews.llvm.org/D40795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D40187: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for' on host

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 318692. Repository: rL LLVM https://reviews.llvm.org/D40187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D39902: [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 317893. Repository: rL LLVM https://reviews.llvm.org/D39902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D39902: [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'

carlo.bertolli created this revision. Simply leverage existing implementation and verify correct functioning with two regression tests. Repository: rL LLVM https://reviews.llvm.org/D39902 Files: include/clang/Basic/OpenMPKinds.def test/OpenMP/teams_distribute_parallel_for_ast_print.cpp

[PATCH] D38371: [OpenMP] Initial implementation of teams distribute code generation

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 314905. Repository: rL LLVM https://reviews.llvm.org/D38371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D32807: [OpenMP] Extended parse for 'always' map modifier

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 302031. Repository: rL LLVM https://reviews.llvm.org/D32807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D32807: [OpenMP] Extended parse for 'always' map modifier

carlo.bertolli created this revision. This patch allows the map modifier 'always' to be separated by the map type (to, from, tofrom) only by a whitespace, rather than strictly by a comma as in current trunk. Repository: rL LLVM https://reviews.llvm.org/D32807 Files: lib/Parse/ParseOpenMP

[PATCH] D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 300802. Repository: rL LLVM https://reviews.llvm.org/D32237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D29922: [OpenMP] Prepare Sema for initial implementation for pragma 'distribute parallel for'

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision r295497 Repository: rL LLVM https://reviews.llvm.org/D29922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D29922: [OpenMP] Prepare Sema for initial implementation for pragma 'distribute parallel for'

carlo.bertolli created this revision. This patch adds two fields for use in the implementation of 'distribute parallel for': 1. The increment expression for the distribute loop. As the chunk assigned to a team is executed by multiple threads within the 'parallel for' region, the increment expr

[PATCH] D28243: [OpenMP] Add missing regression test for pragma distribute, clause firstprivate

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed to r294026 https://reviews.llvm.org/D28243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17840: [OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host code generation

carlo.bertolli closed this revision. carlo.bertolli added a comment. Commited r290898. Repository: rL LLVM https://reviews.llvm.org/D17840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D28243: [OpenMP] Add missing regression test for pragma distribute, clause firstprivate

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, sfantao, kkwli0. carlo.bertolli added subscribers: arpith-jacob, gtbercea, caomhin, cfe-commits. The regression test was missing from the previous already accepted patch. https://reviews.llvm.org/D28243 Files: test