This revision was automatically updated to reflect the committed changes.
Closed by commit rL248977: createUniqueFile() is documented to create the file
in the temporary… (authored by dirty).
Changed prior to commit:
http://reviews.llvm.org/D12774?vs=35463&id=36172#toc
Repository:
rL LLVM
h
Author: dirty
Date: Wed Sep 30 20:24:59 2015
New Revision: 248977
URL: http://llvm.org/viewvc/llvm-project?rev=248977&view=rev
Log:
createUniqueFile() is documented to create the file in the temporary directory
unless it's supplied an absolute path.
Make sure the output filepath supplied to crea
dirty added a comment.
Should I go ahead and commit this change?
http://reviews.llvm.org/D12774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dirty updated this revision to Diff 35463.
dirty added a comment.
- Update patch with feedback from vsk: better handle errors from
make_absolute().
Updating D12774: createUniqueFile() is documented to create the file in the
temporary directory unless it's supplied an absolute path.
dirty added a comment.
Are you suggesting I change the code to something like the following:
if (std::error_code EC =
llvm::sys::fs::make_absolute(Model)) {
llvm::errs() << "warning: could not make '" << Model
<< "' absolute: " << EC.message() << '\n';
return;
dirty added a comment.
Ping?
http://reviews.llvm.org/D12774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dirty created this revision.
dirty added reviewers: rsmith, akyrtzi.
dirty added a subscriber: cfe-commits.
Make sure the output filepath supplied to createUniqueFile() in
HTMLDiagnostics::ReportDiag() is absolute.
http://reviews.llvm.org/D12774
Files:
lib/StaticAnalyzer/Core/HTMLDiagnostics.
dirty created this revision.
dirty added a reviewer: akyrtzi.
dirty added a subscriber: cfe-commits.
Fix a small bug in clang where generating some temporary files would
have an extra period before the extension.
http://reviews.llvm.org/D12627
Files:
lib/ARCMigrate/FileRemapper.cpp
