[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14277 + // FIXME these tests regressed behaviour. // verifyFormat("T A::operator() () {}", SpaceFuncDef); verifyFormat("auto lambda = [] () { return 0; };", SpaceFuncDef); My

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14277 + // FIXME these tests regressed behaviour. // verifyFormat("T A::operator() () {}", SpaceFuncDef); verifyFormat("auto lambda = [] () { return 0; };", SpaceFuncDef); cr

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14125 verifyFormat("typedef void (*cb) (int);", Space); // FIXME these tests regressed behaviour. + verifyFormat("T A::operator() ();", Space); Remove the comment too.

[PATCH] D114696: [clang-format] regressed default behavior for operator parentheses

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14126-14127 + // FIXME these tests regressed behaviour. + // verifyFormat("T A::operator() ();", Space); + // verifyFormat("X A::operator++ (T);", Space); verifyFormat("auto lambda = [] () { r

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14165 + SpaceFuncDecl.SpaceBeforeParens = FormatStyle::SBPO_Custom; + SpaceFuncDecl.SpaceBeforeParensOptions.AfterFunctionDeclarationName = true; + MyDeveloperDay wrote: > are you

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud closed this revision. crayroud added a comment. git revision: 6facafe7da59eb02e8c1519670b503efda2f4b58 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added a comment. I do not have commit access, could you please help with the push? Here are the commit details: C. Rayroud - rayro...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 _

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added a comment. Could you please wait before to push this changes to the main branch, there is one more point I want to verify. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 ___ cfe-comm

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added a comment. I do not have commit access, could you please help with the push. Here are the commit details: C. Rayroud CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 ___ cfe-commits m

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added a comment. I do not have commit access, could you please help with the push. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt