https://github.com/bc-lee closed
https://github.com/llvm/llvm-project/pull/112684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bc-lee wrote:
Original PR: https://github.com/llvm/llvm-project/pull/111375
https://github.com/llvm/llvm-project/pull/112684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bc-lee created
https://github.com/llvm/llvm-project/pull/112684
Failing log: https://lab.llvm.org/buildbot/#/builders/145/builds/2540
>From b6d67fc85457e3c374d7fc0520f593e95e2cbaec Mon Sep 17 00:00:00 2001
From: Byoungchan Lee
Date: Thu, 17 Oct 2024 18:30:28 +0900
Subject: [
bc-lee wrote:
I will fix the following error within an hour (currently away from keyboard).
```
FAILED:
tools/clang/tools/extra/include-cleaner/tool/CMakeFiles/clang-include-cleaner.dir/IncludeCleaner.cpp.o
ccache /home/docker/llvm-external-buildbots/clang.17.0.6/bin/clang++
--gcc-toolchain=
bc-lee wrote:
I don't have commit access to LLVM. Please merge this PR. Thanks!
https://github.com/llvm/llvm-project/pull/111375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bc-lee wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/111375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bc-lee updated
https://github.com/llvm/llvm-project/pull/111375
>From 23b90bba12c010e5882e09e9f6b765a7281324aa Mon Sep 17 00:00:00 2001
From: Byoungchan Lee
Date: Mon, 7 Oct 2024 22:19:38 +0900
Subject: [PATCH 1/9] [clang-include-cleaner] Fix incorrect directory issue for
wr
@@ -49,12 +49,15 @@ int x = foo();
//RUN: FileCheck --match-full-lines --check-prefix=EDIT2 %s < %t.cpp
// EDIT2-NOT: {{^}}#include "foo.h"{{$}}
+// This test has commands that rely on shell capabilities that won't execute
+// correctly on Windows e.g. subshell execut
@@ -48,3 +48,13 @@ int x = foo();
//RUN: clang-include-cleaner -edit --ignore-headers="foobar\.h,foo\.h"
%t.cpp -- -I%S/Inputs/
//RUN: FileCheck --match-full-lines --check-prefix=EDIT2 %s < %t.cpp
// EDIT2-NOT: {{^}}#include "foo.h"{{$}}
+
+//RUN: mkd
@@ -305,8 +307,84 @@ int main(int argc, const char **argv) {
}
}
- clang::tooling::ClangTool Tool(OptionsParser->getCompilations(),
- OptionsParser->getSourcePathList());
+ auto VFS = llvm::vfs::getRealFileSystem();
+ auto &CDB = Option
@@ -305,8 +307,84 @@ int main(int argc, const char **argv) {
}
}
- clang::tooling::ClangTool Tool(OptionsParser->getCompilations(),
- OptionsParser->getSourcePathList());
+ auto VFS = llvm::vfs::getRealFileSystem();
+ auto &CDB = Option
@@ -305,8 +307,84 @@ int main(int argc, const char **argv) {
}
}
- clang::tooling::ClangTool Tool(OptionsParser->getCompilations(),
- OptionsParser->getSourcePathList());
+ auto VFS = llvm::vfs::getRealFileSystem();
+ auto &CDB = Option
@@ -305,8 +307,84 @@ int main(int argc, const char **argv) {
}
}
- clang::tooling::ClangTool Tool(OptionsParser->getCompilations(),
- OptionsParser->getSourcePathList());
+ auto VFS = llvm::vfs::getRealFileSystem();
+ auto &CDB = Option
@@ -305,8 +307,84 @@ int main(int argc, const char **argv) {
}
}
- clang::tooling::ClangTool Tool(OptionsParser->getCompilations(),
- OptionsParser->getSourcePathList());
+ auto VFS = llvm::vfs::getRealFileSystem();
+ auto &CDB = Option
@@ -305,8 +307,84 @@ int main(int argc, const char **argv) {
}
}
- clang::tooling::ClangTool Tool(OptionsParser->getCompilations(),
- OptionsParser->getSourcePathList());
+ auto VFS = llvm::vfs::getRealFileSystem();
+ auto &CDB = Option
https://github.com/bc-lee updated
https://github.com/llvm/llvm-project/pull/111375
>From 23b90bba12c010e5882e09e9f6b765a7281324aa Mon Sep 17 00:00:00 2001
From: Byoungchan Lee
Date: Mon, 7 Oct 2024 22:19:38 +0900
Subject: [PATCH 1/8] [clang-include-cleaner] Fix incorrect directory issue for
wr
https://github.com/bc-lee updated
https://github.com/llvm/llvm-project/pull/111375
>From 23b90bba12c010e5882e09e9f6b765a7281324aa Mon Sep 17 00:00:00 2001
From: Byoungchan Lee
Date: Mon, 7 Oct 2024 22:19:38 +0900
Subject: [PATCH 1/7] [clang-include-cleaner] Fix incorrect directory issue for
wr
https://github.com/bc-lee updated
https://github.com/llvm/llvm-project/pull/111375
>From 23b90bba12c010e5882e09e9f6b765a7281324aa Mon Sep 17 00:00:00 2001
From: Byoungchan Lee
Date: Mon, 7 Oct 2024 22:19:38 +0900
Subject: [PATCH 1/6] [clang-include-cleaner] Fix incorrect directory issue for
wr
https://github.com/bc-lee updated
https://github.com/llvm/llvm-project/pull/111375
>From 23b90bba12c010e5882e09e9f6b765a7281324aa Mon Sep 17 00:00:00 2001
From: Byoungchan Lee
Date: Mon, 7 Oct 2024 22:19:38 +0900
Subject: [PATCH 1/5] [clang-include-cleaner] Fix incorrect directory issue for
wr
@@ -305,7 +342,32 @@ int main(int argc, const char **argv) {
}
}
- clang::tooling::ClangTool Tool(OptionsParser->getCompilations(),
+ auto &CompilationDatabase = OptionsParser->getCompilations();
bc-lee wrote:
I didn't simplify it much, but I tried to
https://github.com/bc-lee updated
https://github.com/llvm/llvm-project/pull/111375
>From 23b90bba12c010e5882e09e9f6b765a7281324aa Mon Sep 17 00:00:00 2001
From: Byoungchan Lee
Date: Mon, 7 Oct 2024 22:19:38 +0900
Subject: [PATCH 1/4] [clang-include-cleaner] Fix incorrect directory issue for
wr
bc-lee wrote:
> in our case this is symlinked to an immutable copy of the source file (to
> make sure builds don't act weird if you edit some sources while the build is
> running). hence it'll be a regression.
>
> What's the concern about not performing this directly as relative to the
> proc
https://github.com/bc-lee edited
https://github.com/llvm/llvm-project/pull/111375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bc-lee updated
https://github.com/llvm/llvm-project/pull/111375
>From 23b90bba12c010e5882e09e9f6b765a7281324aa Mon Sep 17 00:00:00 2001
From: Byoungchan Lee
Date: Mon, 7 Oct 2024 22:19:38 +0900
Subject: [PATCH 1/2] [clang-include-cleaner] Fix incorrect directory issue for
wr
bc-lee wrote:
Could you provide a minimal reproducer for this case if possible? Ideally, it
should not depend on Google's internal Bazel setup or tools. From what I
understand, Bazel itself doesn’t generate compilation databases, and
third-party tools adjust the paths of raw compiler invocatio
bc-lee wrote:
@kadircet @hokein Could you please review this PR? It is related to #102615.
More details are provided in the related issue. Thanks!
https://github.com/llvm/llvm-project/pull/111375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/bc-lee created
https://github.com/llvm/llvm-project/pull/111375
If the current working directory of `clang-include-cleaner` differs from the
directory of the input files specified in the compilation database, it doesn't
adjust the input file paths properly. As a result, `cla
bc-lee wrote:
I'm not the owner of this code, but I just dropped by to say that
I don't think this patch will be accepted. A few lines above your changes,
there is a comment that says, "Please don't add more elements to *Triples.".
@MaskRay is working to reduce the number of target triples like
https://github.com/bc-lee closed https://github.com/llvm/llvm-project/pull/68525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bc-lee wrote:
Since **I'm not an expert in clang AST**, it is hard to reduce the failing
cases. According to my analysis, this crash only happens when the multiple
files are involved, so code reduction tools like creduce doesn't helpful a lot.
Instead, I'm providing an explanation of the crash
bc-lee wrote:
> Is there a way we could come up with a test for this?
Unfortunately, I don't think so. I cannot reduce the 600k lines of preprocessed
code to a small test case that will crash the clang frontend.
https://github.com/llvm/llvm-project/pull/68525
__
https://github.com/bc-lee updated
https://github.com/llvm/llvm-project/pull/68525
>From b272173acb8c2f92b5c5b7ebca4c00e4ac21037c Mon Sep 17 00:00:00 2001
From: Byoungchan Lee
Date: Sun, 8 Oct 2023 21:47:05 +0900
Subject: [PATCH] [Clang][Frontend] Fix a crash when -Wdocumentation is used
This c
https://github.com/bc-lee created
https://github.com/llvm/llvm-project/pull/68525
This commit resolves a crash issue in Clang's frontend caused while using the
`-Wdocumentation` compiler flag.
The flaw was due to the lack of necessary checks before the extraction of text
between the comment a
33 matches
Mail list logo
