[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee added inline comments. Comment at: clang/test/Misc/cc1as-darwin-target-variant-triple.s:2 +// Run cc1as using darwin-target-variant-triple +// RUN: %clang -cc1as -triple x86_64-apple-macos10.9 -darwin-target-variant-triple x86_64-apple-ios13.1-macabi -filetype obj %s -o -

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee updated this revision to Diff 424209. bc-lee added a comment. Add `REQUIRES: x86-registered-target` on the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868/new/ https://reviews.llvm.org/D121868 Files: clang/include/clang/Driver/

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee added a comment. As you confirmed at https://crbug.com/1259122#c21, there is a problem with assembly files like `floatundidf.S` and this patch is intended to fix it. C/C++ files are fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee marked 3 inline comments as done. bc-lee added inline comments. Comment at: clang/test/Misc/cc1as-darwin-target-variant-triple.s:2 +// Run cc1as using darwin-target-variant-triple +// RUN: %clang -cc1as -triple x86_64-apple-macos10.9 -darwin-target-variant-triple x86_64-a

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee updated this revision to Diff 423878. bc-lee added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868/new/ https://reviews.llvm.org/D121868 Files: clang/include/clang/Driver/Options.td clang/include/

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.h:495 + Optional getTargetVariantTriple() const override { +return TargetVariantTriple; + } MaskRay wrote: > llvm::None Do you mean to modify the method in `clang/include/clang/Dri

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee added a comment. Hi, could you have a look at it once more? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868/new/ https://reviews.llvm.org/D121868 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee updated this revision to Diff 417595. bc-lee added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868/new/ https://reviews.llvm.org/D121868 Files: clang/include/clang/Driver/Options.td clang/incl

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee created this revision. bc-lee added reviewers: arphaman, MaskRay. Herald added a project: All. bc-lee requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch extends cc1as to export the build version load command with LC_VERSION_M

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee abandoned this revision. bc-lee added a comment. Closed in favor of https://reviews.llvm.org/D118862 and https://reviews.llvm.org/D118875 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/D117924 __

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

bc-lee added a comment. Hi, I built and tested clang using this patch and https://reviews.llvm.org/D118862. It works great. The current patch adds the -darwin-target-variant flag to all object files for MacOS targets in the compiler_rt's builtin library. However, users building compiler_rt may

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee updated this revision to Diff 405461. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/D117924 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/darwin-sanitizer-ld.c compiler-rt/cmake/bui

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee added a comment. Some changes in this patch were applied as https://reviews.llvm.org/D118759, so I'm re-uploading this patch to get rid of merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee added a comment. For the Chromium side issue is https://crbug.com/1259122. Also I opened LLVM issue https://github.com/llvm/llvm-project/issues/53477. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/D11792

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee added a comment. It may not be appropriate to add other runtime libraries specifically for Mac Catalyst. However, currently `lld` does not allow linking with dynamic libraries with different types of build_version_command, whereas `ld64` does allow for Mac Catalyst. Considering compatibi

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee updated this revision to Diff 402201. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/D117924 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/darwin-sanitizer-ld.c compiler-rt/cmake/bui

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee created this revision. Herald added a subscriber: mgorny. bc-lee requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Mac Catalyst has different platform fields in build_version_command, so it's natural to create a s

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee added a comment. Thanks for the review. Since I don't have commit access, so I want someone else to apply this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee added a comment. Can someone commit my changes on behalf of it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee marked an inline comment as done. bc-lee added a comment. It's okay for some reviewers to make this change on my behalf. Thanks for reviewing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 __

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1970 + but this behavior is changed by another option, + ``JavaStaticImportAfterImport``. MyDeveloperDay wrote: > Can you add a test that shows if the sorting is still in the gro

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290619. bc-lee added a comment. Add more tests and rename options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 Files: clang/docs/ClangFormatStyleOptions.rst clan

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290381. bc-lee added a comment. Fix the example to match the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290303. bc-lee added a comment. Some comments have been corrected and a unittest has been added in FormatTest.ParsesConfigurationBools Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.ll

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2027 + + .. code-block:: java + true: MyDeveloperDay wrote: > The ClangFormatStyleOptions.rst is generated using > doc/tools/dump_format_style.py which reads Format.h and genera

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290246. bc-lee added a comment. Modify the comment of Format.h to sync ClangFormatStyleOptions.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 Files: clang/docs/Cl

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290137. bc-lee added a comment. Add missing initializer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee created this revision. bc-lee added a reviewer: MyDeveloperDay. bc-lee added projects: clang, clang-format. Herald added a subscriber: cfe-commits. bc-lee requested review of this revision. Some Java style guides and IDEs group Java static imports after non-static imports. This patch allow