[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

brunodf added a comment. Hi, I found this review request and I just want to comment that I find it strange that it was rejected. @MaskRay I understand that using a compile_commands.json configured for gcc with clang-based tools is not a supported use case, but still the clang driver was expli

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

brunodf updated this revision to Diff 441294. brunodf added a comment. Adding comment regarding empty subobjects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126956/new/ https://reviews.llvm.org/D126956 Files: clang/lib/CodeGen/CodeGenTBAA.cpp

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

brunodf updated this revision to Diff 441017. brunodf added a comment. Herald added a subscriber: mgrang. New version that fixes the problem with base classes not appearing in order of increasing offset. This issue was discovered in the multistage build, but the test case has now been extended

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

brunodf added a comment. Anyone? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126956/new/ https://reviews.llvm.org/D126956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

brunodf created this revision. brunodf added reviewers: jeroen.dobbelaere, eli.friedman. Herald added a subscriber: kosarev. Herald added a project: All. brunodf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a fix for the miscompi

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:14583 if (Second && Second->getObjectKind() == OK_ObjCProperty) { ExprResult Result = SemaRef.CheckPlaceholderExpr(Second); rjmccall wrote: > rnk wrote: > > This is also pseudo ob

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf requested review of this revision. brunodf added a comment. A stage2 build (outside of the buildloops) is now working correctly. Pinging for new review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111639/new/ https://reviews.llvm.org/D11

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf reopened this revision. brunodf added a comment. This revision is now accepted and ready to land. When the previous diff was committed, two problems were discovered in the buildbots: 1. One pattern in the `PR51855.cpp` test failed on certain targets due to a difference in calling conven

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf updated this revision to Diff 392429. brunodf added a comment. New version of patch to address problems detected by buildbots. (Will describe in more detail in follow-up comment.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111639/new/ h

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf added a comment. In D111639#3081504 , @brunodf wrote: > With regard to OO_Subscript, OO_Arrow and OO_Amp, I have tried a number of > things, but I have not succeeded in triggering that an CXXOperatorCallExpr is > created for these operators (t

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf updated this revision to Diff 381639. brunodf marked 3 inline comments as done. brunodf added a comment. I'm adding a new patch to (partially) address the comments from @rnk. An ObjC test case was included in the commit from @akyrtzi, I've updated it to also cover the case of a unary ope

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf updated this revision to Diff 380885. brunodf edited the summary of this revision. brunodf added a reviewer: akyrtzi. brunodf added a subscriber: akyrtzi. brunodf added a comment. @rnk raises the remark that TreeTransform::RebuildCXXOperatorCallExpr already contains code to handle ObjC ps

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf updated this revision to Diff 379958. brunodf added a comment. Apply clang-format to diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111639/new/ https://reviews.llvm.org/D111639 Files: clang/lib/Sema/TreeTransform.h clang/test/Sema

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf added a comment. In D111639#3065241 , @rnk wrote: > There are some invariants about what family of APIs TreeTransform methods > should call, and I've forgotten what they are, so I'm hesitant to approve > this. Test case looks good, though. I am

[PATCH] D111639: [PR51855] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf created this revision. brunodf added a reviewer: jeroen.dobbelaere. brunodf added a project: clang. brunodf requested review of this revision. Herald added a subscriber: cfe-commits. The invocation of a unary or binary operator for type-dependent expressions is represented as a CXXOperato

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

brunodf added a comment. This change is important make better use of `#pragma clang attribute` (which is cool!), but for some uses the check still seems to restrictive. Concretely, for an attribute where `Subjects` includes `FunctionLike`, I can only match it using the rule `hasType(functionTyp

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

brunodefraine updated this revision to Diff 354922. brunodefraine added a comment. Slightly improved test case (both C and C++). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104777/new/ https://reviews.llvm.org/D104777 Files: clang/lib/CodeGen/

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

brunodefraine added a comment. Following suggestion by @dblaikie and @aaron.ballman I'm preparing a new diff where a function redeclaration that adds `nodebug` is flagged as an error in `Sema::mergeDeclAttributes`. This triggers test failures because of violations in builtin header files, for

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

brunodefraine added a subscriber: probinson. brunodefraine added a comment. In D104777#2836669 , @dblaikie wrote: > Yeah, all that sounds reasonable to me - @brunodefraine could you look into > supporting nodebug in a similar way as @aaron.ballman has de

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

brunodefraine updated this revision to Diff 353949. brunodefraine added a comment. Fix issues from Windows/clang-format buildbot. Fix mistake in code comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104777/new/ https://reviews.llvm.org/D10477

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

brunodefraine created this revision. brunodefraine added reviewers: ychen, dblaikie. brunodefraine added a project: clang. brunodefraine requested review of this revision. Herald added a subscriber: cfe-commits. Fix suggested by Yuanfang Chen: Non-distinct debuginfo is attached to the function du

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

bdf added a comment. In D88363#2319157 , @jmorse wrote: > In D88363#2317241 , @Mordante wrote: > >> Can you explain the kind of issues you're having? > > At the shallowest level, our -O1 produces different IR and fa

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

bdf accepted this revision. bdf added a comment. This revision is now accepted and ready to land. Looks good. Good idea to add tests to verify that we match `__builtin_except()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88363/new/ https://revi

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

brunodf added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2025 +ThisPtr = +Builder.CreatePointerBitCastOrAddrSpaceCast(This.getPointer(), NewType); } rjmccall wrote: > Anastasia wrote: > > I am a bit unsure if `performAddrSpaceCast` shoul

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

brunodf added inline comments. Comment at: lib/Sema/SemaType.cpp:4877 T = Context.getFunctionType(T, ParamTys, EPI); T = state.getSema().Context.getAddrSpaceQualType(T, AS); } else { I follow all of the above (from the point "a clas