[PATCH] D124982: [clang][OpenMP][DebugInfo] Debug support for variables in containing scope of OMP constructs

2022-05-10 Thread Brock Wyma via Phabricator via cfe-commits
bwyma added a comment. If the parent function is inlined into multiple callers, is the outlined subprogram scope treated like any other nested lexical scope and duplicated? If the outlined subprogram scope is duplicated when inlined, how will retained nodes on the outlined subprogram be handled

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

2022-01-25 Thread Brock Wyma via Phabricator via cfe-commits
bwyma added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:812-814 + // CodeView types with C++ mangling need a type identifier. + if (CGM.getCodeGenOpts().EmitCodeView) +return true; dblaikie wrote: > rnk wrote: > > rnk wrote: > > > dblaikie wrot

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

2018-05-22 Thread Brock Wyma via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC332975 (authored by bwyma, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D45438?vs=146612&id=147988#toc Repository: rC Clang https://review