[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman added a comment. Thank you for reviewing @kadircet! Per the MyFirstTypoFix page , I don’t have commit access. If everything looks good, could you land this patch for me and use “Brian Gluzman bgluz...@gmail.com” for the commit? Reposito

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman updated this revision to Diff 525722. bgluzman added a comment. resubmit diff update with corrected commit range Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151294/new/ https://reviews.llvm.org/D151294 Files: clang-tools-extra/clangd/

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:137 +llvm::Expected +getDelKeywordReplacements(const FunctionDecl *FD, + const syntax::TokenBuffer &TokBuf, kadircet wrote: > let's jus

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman updated this revision to Diff 525715. bgluzman added a comment. address diff comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151294/new/ https://reviews.llvm.org/D151294 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutli

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:136 +// Removes matching instances of given token preceeding the function defition. +llvm::Expected +getDelKeywordReplacements(const FunctionDecl *FD, This was

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman created this revision. bgluzman added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. bgluzman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. `in