[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon marked an inline comment as done. bcahoon added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:471 + "true", + "Encoding format GFX10_A" +>; foad wrote: > I realise you're just following the precedent set by GFX10_B, but is this > termin

[PATCH] D103663: [AMDGPU] Add gfx1013 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea10a86984ea: [AMDGPU] Add gfx1013 target (authored by bcahoon). Changed prior to commit: https://reviews.llvm.org/D103663?vs=350468&id=350640#toc

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon updated this revision to Diff 350468. bcahoon added a comment. Addressed review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103663/new/ https://reviews.llvm.org/D103663 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/AMD

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4700 +B.getMF().getFunction().getContext().diagnose(BadIntrin); +B.buildUndef(MI.getOperand(0)); +MI.eraseFromParent(); rampitec wrote: > rampitec wrote: > > Jus

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon updated this revision to Diff 350448. bcahoon added a comment. Changed legalizer to return false for raytracing intrinsics that are not supported by the subtarget. I changed both GlobalISel and regular ISel to work similarly. A crash occurs with a message that the intrinsic cannot be le

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon marked an inline comment as done. bcahoon added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:7341 +if (!Subtarget->hasGFX10_AEncoding()) + emitRemovedIntrinsicError(DAG, DL, Op.getValueType()); + rampitec wrote: > return

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon updated this revision to Diff 350423. bcahoon added a comment. Addressed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103663/new/ https://reviews.llvm.org/D103663 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/AMD

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon marked 4 inline comments as done. bcahoon added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.intersect_ray.ll:4 +; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1013 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s +; RUN: llc -g

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon marked 8 inline comments as done. bcahoon added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:389 - xnack scratch - *pal-amdpal* + ``gfx1013`` ``amdgcn`` dGPU - cumode

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon updated this revision to Diff 350075. bcahoon added a comment. Addressed review comments. Updated the patch to use the new AEncoding target feature correctly. Added code to report an error for the image intersect intrinsics for unsupported targets. CHANGES SINCE LAST ACTION https://re

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon created this revision. bcahoon added reviewers: rampitec, kzhuravl. Herald added subscribers: foad, dexonsmith, kerbowa, rupprecht, jfb, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, emaste, arsenm, jholewinski. Herald added a reviewer: jhenderson. Herald added a reviewer: M

[PATCH] D49999: [Hexagon] Remove fp-contract=fast setting for at O3

This revision was automatically updated to reflect the committed changes. Closed by commit rC342078: [Hexagon] Remove fp-contract=fast setting for at O3 (authored by bcahoon, committed by ). Changed prior to commit: https://reviews.llvm.org/D4?vs=158029&id=165143#toc Repository: rC Clang

[PATCH] D49999: [Hexagon] Remove fp-contract=fast setting for at O3

bcahoon created this revision. bcahoon added a reviewer: kparzysz. Herald added a subscriber: cfe-commits. Change Hexagon so that the setting for fp-contract is the default setting. This makes Hexagon consistent with all the other targets. Repository: rC Clang https://reviews.llvm.org/D4

[PATCH] D48571: improve diagnostics for missing 'template' keyword

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL335641: [Hexagon] Add a "generic" cpu (authored by bcahoon, committed by ). Herald added a subscriber: llvm-commits. Chan