listout added a comment.
Hey everyone, it would be very helpful if someone looked at this and help me
merge this patch, python3.11 is failing without these modifications
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131563/new/
https://reviews.llvm.org/D131563
listout updated this revision to Diff 456920.
listout marked an inline comment as done.
listout retitled this revision from "[WIP] [clang] Fix clang multiarch isssue
with musl" to "[clang] Fix clang multiarch isssue with musl".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131563/new/
ht
listout marked an inline comment as done.
listout added a comment.
@barannikov88 made some changes. What do you think?
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:49
+ std::string EnvName = TargetTriple.isMusl() ? "musl" : "gnu";
+
barannikov88 wrote:
listout updated this revision to Diff 451757.
listout added a comment.
Using `getEnvironmentTypeName()` instead of `isMusl()`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131563/new/
https://reviews.llvm.org/D131563
Files:
clang/lib/Driver/ToolChains/Linux.cpp
Index: clang/lib/Dri
listout updated this revision to Diff 451572.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131563/new/
https://reviews.llvm.org/D131563
Files:
clang/lib/Driver/ToolChains/Linux.cpp
Index: clang/lib/Driver/ToolChains/Linux.cpp
=
listout updated this revision to Diff 451459.
listout added a comment.
Fix missing '+'
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131563/new/
https://reviews.llvm.org/D131563
Files:
clang/lib/Driver/ToolChains/Linux.cpp
Index: clang/lib/Driver/ToolChains/Linux.cpp
==
listout updated this revision to Diff 451452.
listout added a comment.
Herald added subscribers: pcwang-thead, luke957, s.egerton, simoncook.
Less drastic changes and rebased with main
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131563/new/
https://reviews.llvm.org/D131563
Files:
c
listout added a comment.
The patch needs some rework for 15.x and above version. If people think it's
appropriate then I'll be glad to make the changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131563/new/
https://reviews.llvm.org/D131563
___
listout created this revision.
listout added reviewers: dlj, atanasyan, MaskRay, Bdragon28.
Herald added subscribers: StephenFan, pengfei, fedor.sergeev, kristof.beyls.
Herald added a project: All.
listout requested review of this revision.
Herald added a project: clang.
Herald added a subscriber:
