Re: [PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.

2017-11-22 Thread Billy O';Neal via cfe-commits
OK, I think r318830 fixes the other one here. Thanks! Billy3 On Wed, Nov 22, 2017 at 4:25 AM, Billy O'Neal wrote: > Sorry, I saw one bot fail and I thought I fixed it with > 37332d772480307af423fbea817c29a0832be86e but apparently there were > others I missed. > > On Wed, Nov 22, 2017 at 4:04 AM,

Re: [PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.

2017-11-22 Thread Billy O';Neal via cfe-commits
Sorry, I saw one bot fail and I thought I fixed it with 37332d772480307af423fbea817c29a0832be86e but apparently there were others I missed. On Wed, Nov 22, 2017 at 4:04 AM, Evgeny Astigeevich wrote: > Hi Billy, > > These changes caused buildbot failures: tuple.by.type.fail.cpp Line 19: > unknown

Re: [PATCH] D33708: [test] [libcxx] Disable MSVC++'s compare(a, b) implies !compare(b, a) assertion in predicate application count tests

2017-06-05 Thread Billy O';Neal via cfe-commits
But I actually want the predicate count assertions turned on -- if a user turns off iterator debugging they need to get exactly what the standard asks for, and that means both predicate assertions like this and the Iterator Debug Array Overloads go away. I need to figure out how to do this with ou