CrisCristescu updated this revision to Diff 65528.
CrisCristescu added a comment.
Wrong indentation update.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeCompleteConsumer.h
lib/Lex/Lexer.cpp
lib/Lex/Preprocessor.cpp
CrisCristescu updated this revision to Diff 65508.
CrisCristescu marked an inline comment as done.
CrisCristescu added a comment.
Some more cosmetics.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeCompleteConsumer.h
l
CrisCristescu updated this revision to Diff 65403.
CrisCristescu marked an inline comment as done.
CrisCristescu added a comment.
PP CodeCompletionII initialisation.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeComplet
CrisCristescu updated this revision to Diff 65401.
CrisCristescu marked 3 inline comments as done.
CrisCristescu added a comment.
Addressing some sugesstions.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeCompleteConsum
CrisCristescu updated this revision to Diff 56115.
CrisCristescu added a comment.
Addresses the previous comments and adds testing for filtering.
All the tests already in CodeCompletion are testing both the backward
compatibility and the new functionality itself.
Repository:
rL LLVM
http://
CrisCristescu added a comment.
For the filtering itself the motivation for not doing it on the client side is
the following in our use case:
- we do not re-filter on every key stroke, we only filter when the key is
pressed i.e there is one completion point;
- we have a PCH which will help with
CrisCristescu updated this revision to Diff 51404.
CrisCristescu added a comment.
The code_completion token now stores the information, if there is one,
about the identifier that it is lexing.
During the parsing there is a common entry point which is ConsumerToken
where we can set the information
CrisCristescu created this revision.
CrisCristescu added reviewers: clang-c, benlangmuir, akyrtzi.
CrisCristescu added a subscriber: cfe-commits.
CrisCristescu set the repository for this revision to rL LLVM.
CrisCristescu changed the visibility of this Differential Revision from "Public
(No Login
