[PATCH] D67057: [AST][JSON] Generate parent context id from Decl* instead of DeclContext*

piscisaureus marked an inline comment as done. piscisaureus added a comment. Fixed nit, this is ready to land IMO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67057/new/ https://reviews.llvm.org/D67057 ___ cfe-commits mailing list cfe-com

[PATCH] D67057: [AST][JSON] Generate parent context id from Decl* instead of DeclContext*

piscisaureus updated this revision to Diff 218770. piscisaureus added a comment. fix nit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67057/new/ https://reviews.llvm.org/D67057 Files: clang/lib/AST/JSONNodeDumper.cpp clang/test/AST/ast-dump-decl-context-json.cpp clang/test/AST/a

[PATCH] D67057: [AST][JSON] Generate parent context id from Decl* instead of DeclContext*

piscisaureus created this revision. piscisaureus added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because of multiple inheritance, a DeclContext pointer does not produce the same pointer representation as a Decl pointer that references the sam

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

piscisaureus added a comment. @aaron.ballman I was able to run the tests, I think this is good to go. Can you help me get it landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66850/new/ https://reviews.llvm.org/D66850 ___

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

piscisaureus updated this revision to Diff 217730. piscisaureus added a comment. Add missing CHECK_NEXT line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66850/new/ https://reviews.llvm.org/D66850 Files: clang/lib/AST/JSONNodeDumper.cpp clang

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

piscisaureus added a comment. In D66850#1649865 , @aaron.ballman wrote: > In D66850#1649708 , @piscisaureus > wrote: > > > In D66850#1648776 , @aaron.ballman > > wrote: >

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

piscisaureus updated this revision to Diff 217713. piscisaureus added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66850/new/ https://reviews.llvm.org/D66850 Files: clang/lib/AST/JSONNodeDumper.cpp clang/test/AST/ast-dump-

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

piscisaureus added a comment. In D66850#1648776 , @aaron.ballman wrote: > LGTM, but missing a test case. > > In D66850#1648557 , @sidorovd wrote: > > > LGTM. I'm not an expert in JSON, but may be it makes sense to

[PATCH] D66850: Avoid crash when dumping NULL Type as JSON

piscisaureus updated this revision to Diff 217545. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66850/new/ https://reviews.llvm.org/D66850 Files: clang/lib/AST/JSONNodeDumper.cpp Index: clang/lib/AST/JSONNodeDumper.cpp

[PATCH] D66850: Do not attempt visit child nodes of NULL type

piscisaureus created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66850 Files: clang/include/clang/AST/ASTNodeTraverser.h Index: clang/include/clang/AST/ASTNodeTraverser.h ===