Re: [PATCH] D20014: [libc++] Explicit return in non-void function

2016-05-06 Thread Bernard Ogden via cfe-commits
bogden added a comment. I think this fix is OK, but I'm not clear on why we need both C and D, so perhaps it is important that the function does not have a return statement. http://reviews.llvm.org/D20014 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D20014: [libc++] Explicit return in non-void function

2016-05-06 Thread Bernard Ogden via cfe-commits
bogden created this revision. bogden added a reviewer: EricWF. bogden added a subscriber: cfe-commits. This test contains a non-void function with no explicit return, causing it to fail when built with -Werror=return-type. This patch adds a return to the function. http://reviews.llvm.org/D20014