[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

2018-10-10 Thread Benjamin Buch via Phabricator via cfe-commits
bebuch accepted this revision. bebuch added a comment. This revision is now accepted and ready to land. Okay, sorry for the blockage! https://reviews.llvm.org/D42242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

2018-01-24 Thread Benjamin Buch via Phabricator via cfe-commits
bebuch requested changes to this revision. bebuch added a comment. This revision now requires changes to proceed. I get some new errors: /home/pi/projects/llvm/llvm/projects/libcxxabi/src/cxa_personality.cpp: In function ‘void __cxxabiv1::scan_eh_tab(__cxxabiv1::{anonymous}::scan_results&, _U

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

2018-01-22 Thread Benjamin Buch via Phabricator via cfe-commits
bebuch added a comment. Thanks for the amazing patch! I get another error: /home/pi/projects/llvm/llvm/projects/libcxxabi/src/cxa_default_handlers.cpp: In function ‘void demangling_terminate_handler()’: /home/pi/projects/llvm/llvm/projects/libcxxabi/src/cxa_default_handlers.cpp:41:58: err

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

2017-12-12 Thread Benjamin Buch via Phabricator via cfe-commits
bebuch accepted this revision. bebuch added a comment. Please commit! https://reviews.llvm.org/D38831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34096: [Sema][C++1z] Ensure structured binding's bindings in dependent foreach have non-null type

2017-06-16 Thread Benjamin Buch via Phabricator via cfe-commits
bebuch reopened this revision. bebuch added a comment. This revision is now accepted and ready to land. I believe this patch is incomplete, I get a very odd warning: struct A{ int x; }; template < typename > struct B{ A data_[1]; void f(){ for(auto [x]: d