Re: [PATCH] D23421: [Clang-tidy] CERT-MSC53-CPP (checker for std namespace modification)

Unfortunatelly I wont have time now to work on this check... Thank you for understanding! On Mon, Feb 6, 2017 at 3:44 PM, Gábor Horváth via Phabricator < revi...@reviews.llvm.org> wrote: > xazax.hun added a comment. > > Benedek, do you have time to address the review comments or do you want me >

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho added a comment. Thanks ! https://reviews.llvm.org/D22346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho added a comment. I just figured out that I don't have right to commit to llvm so I would appreciate if you could commit this check for me. Do you need any info about me? Thank you! https://reviews.llvm.org/D22346 ___ cfe-commits mailing list

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho added a comment. Thanks but I think I will try it! https://reviews.llvm.org/D22346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho added a comment. Cool! Thank you for the reviews! https://reviews.llvm.org/D22346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho updated this revision to Diff 76072. falho marked an inline comment as done. falho added a comment. in cpp diagnostics message: comma changed back to semicolon, + curly braces removed testfiles corrected accordingly https://reviews.llvm.org/D22346 Files: clang-tidy/cert/CERTTidyModule.

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho updated this revision to Diff 75935. falho marked an inline comment as done. falho added a comment. removed semicolon, and replaced it with a comma that only appears in .cpp diagnostics test cases corrected according to this removed junk .swo file https://reviews.llvm.org/D22346 Files:

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho updated this revision to Diff 75460. falho added a comment. changes according to 2nd review https://reviews.llvm.org/D22346 Files: clang-tidy/cert/.LimitedRandomnessCheck.cpp.swo clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/LimitedRandomnessChe

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho removed rL LLVM as the repository for this revision. falho updated this revision to Diff 74908. falho added a comment. Herald added subscribers: modocache, mgorny, beanz. updated diff according to first reviews https://reviews.llvm.org/D22346 Files: clang-tidy/cert/.LimitedRandomnessChe

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho marked 5 inline comments as done. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0)))

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho added a comment. Hi! Thanks for the reviews! I will be off for a few days so I will start working on it when Im back. Greetz! Benedek Repository: rL LLVM https://reviews.llvm.org/D22346 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D23427: [Clang-tidy] Comparison Misuse

falho created this revision. falho added reviewers: xazax.hun, o.gyorgy, alexfh, aaron.ballman, etienneb, hokein, Prazek. falho added a subscriber: cfe-commits. falho set the repository for this revision to rL LLVM. This checker warns for the misuse of comparison operators - char* is compared to