[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

puremourning added a comment. Erm, doh. I thought I was on main, but I was using clang 12.0.0 (tag llvmorg-10.0.0 from llvm-project). We tend to only use release tagged versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93565/new/ https://rev

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

puremourning added a comment. In D93565#2770709 , @puremourning wrote: > Unless i'm missing something, this change seems to have broken scan-view, as > it now just says > > "ModuleNotFOundError: No module named 'Reporter'" > > Due to : > > `import Report

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

puremourning added a comment. Unless i'm missing something, this change seems to have broken scan-view, as it now just says "ModuleNotFOundError: No module named 'Reporter'" Due to : `import Reporter` in `ScanView.py` Am i losing my mind? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. In D66254#1630283 , @puremourning wrote: > In D66254#1630277 , @lebedev.ri > wrote: > > > Tests? > > > Per my comment: I haven't added new tests to HeaderSearchTest.cc because the >

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. In D66254#1630277 , @lebedev.ri wrote: > Tests? Per my comment: I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. FYI this fixes the issue in https://github.com/clangd/clangd/issues/124 I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this patch. Let me know thoughts on alte

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning created this revision. puremourning added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, ilya-biryukov. Herald added a project: clang. puremourning added a comment. FYI this fixes the issue in https://github.com/clangd/clangd/issues/124 I haven't added new te

[PATCH] D66056: Add 2 tests which cover the hover result for auto

puremourning created this revision. puremourning added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Clangd supports reporting the deduced type when hovering on 'auto', but does not report it when hovering

[PATCH] D66038: [clangd] Give absolute path to clang-tidy and include-fixer. HintPath should always be absolute, some URI schemes care.

puremourning added a comment. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66038/new/ https://reviews.llvm.org/D66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D66031: clangd: use -j for background index pool

puremourning added a comment. In D66031#1623855 , @sammccall wrote: > Thanks! Want me to land this for you? yes please! I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214463. puremourning added a comment. Rebase on master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/ https://reviews.llvm.org/D66031 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-t

[PATCH] D66031: clangd: use -j for background index pool

puremourning marked an inline comment as done. puremourning added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { sammccall wrote: > puremourning wrote: >

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214460. puremourning marked an inline comment as not done. puremourning added a comment. Herald added subscribers: jfb, javed.absar. Always use physical cores rather than logical cores for best performance. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D66031: clangd: use -j for background index pool

puremourning added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { sammccall wrote: > can we use `std::max(Opts.AsyncThreadsCount, 1)` instead? > > Havin

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214454. puremourning marked 3 inline comments as done. puremourning added a comment. When -sync -background-index supplied, use 1 thread for background index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D66031: clangd: use -j for background index pool

puremourning created this revision. puremourning added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. clangd supports a -j option to limit the amount of threads to use for parsing TUs. However, when using -bac

[PATCH] D37282: clangd: Tolerate additional headers

puremourning added a comment. In https://reviews.llvm.org/D37282#860200, @ilya-biryukov wrote: > Looks good and ready to land. Thanks for this change. > Do you have commit rights to llvm repo? Thanks for the review! No I don't have commit rights. Can you land for me? Thanks! https://reviews

[PATCH] D37282: clangd: Tolerate additional headers

puremourning added a comment. So I think this is ready now. Anything more you need from me? Comment at: clangd/JSONRPCDispatcher.cpp:138 bool &IsDone) { + unsigned long long ContentLength = 0; while (In.good()) { puremour

[PATCH] D37282: clangd: Tolerate additional headers

puremourning updated this revision to Diff 113476. puremourning added a comment. Validate that the duplicate message is printed. https://reviews.llvm.org/D37282 Files: clangd/JSONRPCDispatcher.cpp test/clangd/protocol.test Index: test/clangd/protocol.test ==