bviyer added a comment.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D50122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bviyer marked an inline comment as done.
bviyer added a comment.
John, I have updated the test case as you requested (I think). I am a bit new
to Clang, so apologize if I mistook your request.
https://reviews.llvm.org/D49952
___
cfe-commits mailing
bviyer updated this revision to Diff 159353.
https://reviews.llvm.org/D49952
Files:
lib/CodeGen/CGExprConstant.cpp
test/CodeGenCXX/empty-struct-init-list.cpp
Index: test/CodeGenCXX/empty-struct-init-list.cpp
===
--- /dev/null
+
bviyer updated this revision to Diff 158870.
bviyer added a comment.
Simplified the case a bit more as requested by Erik. I also induced some errors
in the test so that if someone symbolic-linked clang to /bin/true, the test
will fail.
Repository:
rC Clang
https://reviews.llvm.org/D50122
F
bviyer updated this revision to Diff 158676.
bviyer added a comment.
Added FileCheck as requested by John McCall
Made comments start with "//" instead of /*
Removed expected-no-diagnostics from the test case (as requested by Erik)
Repository:
rC Clang
https://reviews.llvm.org/D49952
Files:
bviyer created this revision.
bviyer added reviewers: erik.pilkington, ahatanak, arphaman, dexonsmith.
Herald added a subscriber: cfe-commits.
When a variable is defined in the init capture and it is of type struct that is
dependent on additional structure, its definition is not found. An excepti
bviyer updated this revision to Diff 158392.
bviyer added a comment.
Forgot to pass the -emit-llvm to the test case.
https://reviews.llvm.org/D49952
Files:
lib/CodeGen/CGExprConstant.cpp
test/CodeGenCXX/empty-struct-init-list.cpp
Index: test/CodeGenCXX/empty-struct-init-list.cpp
=
bviyer updated this revision to Diff 158391.
bviyer added a comment.
Fixed code as suggested by John McCall.
Repository:
rC Clang
https://reviews.llvm.org/D49952
Files:
lib/CodeGen/CGExprConstant.cpp
test/CodeGenCXX/empty-struct-init-list.cpp
Index: test/CodeGenCXX/empty-struct-init-li
bviyer created this revision.
bviyer added reviewers: arphaman, dexonsmith, ahatanak, rjmccall.
While emitting Array Constant, if the destination type is null-pointer, it will
cause an assert. This patch will check if the destination type is null, and if
so then it will just return nullptr as th
bviyer updated this revision to Diff 157730.
bviyer added a comment.
Fixed the comment as you suggested.
I do not have check in rights yet. Can you please check it in for me?
Repository:
rC Clang
https://reviews.llvm.org/D49766
Files:
include/clang/AST/TemplateBase.h
test/SemaObjCXX/cla
bviyer updated this revision to Diff 157721.
bviyer added a comment.
I have fixed all the changes requested by Erik along with shortening the test
case.
Repository:
rC Clang
https://reviews.llvm.org/D49766
Files:
include/clang/AST/TemplateBase.h
test/SemaObjCXX/class-templ-error-null-in
bviyer created this revision.
bviyer added reviewers: arphaman, erik.pilkington, dexonsmith.
Herald added a subscriber: cfe-commits.
When the error has occurred for one of the variables inside a template, the Loc
function will try to find the end-location of the final item. If this variable
is d
bviyer abandoned this revision.
bviyer added a comment.
Thank you Eric. I abandoned the revision as you suggested.
Repository:
rC Clang
https://reviews.llvm.org/D48506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
bviyer added a comment.
Herald added a subscriber: dexonsmith.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D48506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bviyer created this revision.
bviyer added reviewers: rsmith, arphaman.
There was a crash when qualtype is null in the function
Sema::ActOnCXXNestedNameSpecifierDecltype. If it is null then just return
without processing it further.
Repository:
rC Clang
https://reviews.llvm.org/D48506
File
15 matches
Mail list logo