ayokunle321 wrote:
@erichkeane CI is happy now! For future patches, I was wondering if to separate
them like this so reviews could be easier or I should just do it all in one PR.
https://github.com/llvm/llvm-project/pull/130868
___
cfe-commits mailing
https://github.com/ayokunle321 edited
https://github.com/llvm/llvm-project/pull/130868
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayokunle321 wrote:
Okay cool. I'll change the option's name but for the .td file, I don't think it
had a newline at the end initially (just checked the main repo). I could easily
add it but just wanted to clarify.
And yeah we can merge this one for now and when I'm able to find more I'll make
https://github.com/ayokunle321 updated
https://github.com/llvm/llvm-project/pull/130868
>From dfc517be06531af965dc51b09a0f1ae7965e3e20 Mon Sep 17 00:00:00 2001
From: Ayokunle Amodu <121697771+ayokunle...@users.noreply.github.com>
Date: Fri, 14 Mar 2025 15:13:05 -0600
Subject: [PATCH 1/6] revert
https://github.com/ayokunle321 updated
https://github.com/llvm/llvm-project/pull/130868
>From dfc517be06531af965dc51b09a0f1ae7965e3e20 Mon Sep 17 00:00:00 2001
From: Ayokunle Amodu <121697771+ayokunle...@users.noreply.github.com>
Date: Fri, 14 Mar 2025 15:13:05 -0600
Subject: [PATCH 1/4] revert
ayokunle321 wrote:
@erichkeane Hey! So I was able to change one, could you please take a look.
Also for this case:
Instruction:
%select{classdesign|coclass|dependency|helper"
"|helperclass|helps|instancesize|ownership|performance|security|superclass}1
Use:
https://github.com/user-attachments
https://github.com/ayokunle321 updated
https://github.com/llvm/llvm-project/pull/130868
>From dfc517be06531af965dc51b09a0f1ae7965e3e20 Mon Sep 17 00:00:00 2001
From: Ayokunle Amodu <121697771+ayokunle...@users.noreply.github.com>
Date: Fri, 14 Mar 2025 15:13:05 -0600
Subject: [PATCH 1/2] revert
ayokunle321 wrote:
@erichkeane thanks a lot for the clarification. I think I have a hang of it
now- I was kinda confused before. Now, my approach is to look through
DiagnosticXKinds.td files -> check for a `select` with a significant number of
items -> check its diagnostic ID -> grep the lib d