[PATCH] D152401: CGExprCXX: emit family and allockind attributes

durin42 added a comment. FYI: this is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152401/new/ https://reviews.llvm.org/D152401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 added a comment. FYI: this is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121629/new/ https://reviews.llvm.org/D121629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 added a comment. FYI: this is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 added a comment. FYI: this is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152400: CodeGen: hand two tests to the care of update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0bd281eceff5: CodeGen: hand two tests to the care of update_cc_test_checks (authored by durin42). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D152401: CGExprCXX: emit family and allockind attributes

durin42 edited the summary of this revision. durin42 updated this revision to Diff 529617. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152401/new/ https://reviews.llvm.org/D152401 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGenCXX/cx

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 updated this revision to Diff 529615. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121629/new/ https://reviews.llvm.org/D121629 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/catch-alignm

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 updated this revision to Diff 529616. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-align-attr.c clang/test/CodeGen/alloc-fns-ali

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 updated this revision to Diff 529613. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGen/pr53127.cpp clang/test/CodeGenCXX/cxx1y-sized-de

[PATCH] D152400: CodeGen: hand two tests to the care of update_cc_test_checks

durin42 edited the summary of this revision. durin42 updated this revision to Diff 529614. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152400/new/ https://reviews.llvm.org/D152400 Files: clang/test/CodeGen/catch-alignment-assumption-attribute-a

[PATCH] D152401: CGExprCXX: emit family and allockind attributes

durin42 created this revision. Herald added subscribers: JDevlieghere, hiraditya. Herald added a project: All. durin42 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This allows us to remove most of the special knowledge

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 updated this revision to Diff 529447. durin42 requested review of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-alig

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 updated this revision to Diff 529446. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121629/new/ https://reviews.llvm.org/D121629 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/catch-alignm

[PATCH] D152400: CodeGen: hand two tests to the care of update_cc_test_checks

durin42 created this revision. Herald added a project: All. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These two tests were pretty challenging to manage by hand, and in rebasing the next change in my stack I finally ran out of

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 updated this revision to Diff 529444. durin42 requested review of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGen/pr53127

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 planned changes to this revision. durin42 added a comment. I'll hold off on this one until the other LLVM patches are done, then mail out the clang work as its own logical unit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ htt

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 updated this revision to Diff 420915. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGenCXX/cxx1y-sized-deallocation.cpp clang/test/CodeG

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 edited the summary of this revision. durin42 updated this revision to Diff 420854. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGenCXX/cx

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 planned changes to this revision. durin42 added a comment. I have some reworking to do on this after my latest round of llvm-side work that I'll try and get out later this week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ htt

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 created this revision. Herald added a project: All. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this change, we're almost ready to drop the entire table out of MemoryBuiltins.cpp and rely solely on attributes to det

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 added a comment. In D121629#3380191 , @durin42 wrote: > In D121629#3380175 , @lebedev.ri > wrote: > >> Please can you pose the next patch itself? >> I suspect that propagation should simply not be done wh

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 retitled this revision from "CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign" to "clang: emit allocalign to LLVM for alloc_align attributes". durin42 edited the summary of this revision. durin42 updated this revision to Diff 415230. Herald added a project: All. Rep

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 updated this revision to Diff 415226. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121629/new/ https://reviews.llvm.org/D121629 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/catch-alignm

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 added a comment. In D121629#3380175 , @lebedev.ri wrote: > Please can you pose the next patch itself? > I suspect that propagation should simply not be done when sanitizer is > enabled. I'm working on the next patch. Sadly we can't omit `alloca

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 created this revision. Herald added a project: All. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this patch, we only check alloc_alignment claims in the caller. I'm about to add some extra logic that threads allo

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 updated this revision to Diff 410896. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-align-attr.c clang/test/CodeGen/alloc-fns-ali

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 updated this revision to Diff 410558. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-align-attr.c clang/test/CodeGen/alloc-fns-ali

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 updated this revision to Diff 410058. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-align-attr.c clang/test/CodeGen/alloc-fns-ali

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

durin42 added a comment. In D114543#3319638 , @chill wrote: > In D114543#3319587 , @durin42 wrote: > >> > > > >> Is the parameter optional if uwtable is set programmatically, or only when >> we're reading IR str

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

durin42 added a comment. In D114543#3319576 , @chill wrote: > In D114543#3319347 , @durin42 wrote: > >> As far as I can tell this patch broke the Rust compiler, but from the commit >> message it sounds like it sh

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

durin42 added a comment. As far as I can tell this patch broke the Rust compiler, but from the commit message it sounds like it shouldn't have? https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/8358#e85ad6f3-9992-4ea1-9cd3-d8db9f45f33e fails with Attribute 'uwtable' sho

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 updated this revision to Diff 408116. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-align-attr.c clang/test/CodeGen/alloc-fns-ali

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 updated this revision to Diff 408097. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-align-attr.c clang/test/CodeGen/alloc-fns-ali

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 edited the summary of this revision. durin42 updated this revision to Diff 408019. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-al

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4605 + TryEmitAsCallSiteAttribute(const llvm::AttributeList &Attrs) { +llvm::AttributeList NewAttrs = Attrs; +if (AA) jyknight wrote: > We do need to fallback to an assume for > "if

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 added inline comments. Comment at: clang/test/CodeGen/alloc-align-attr.c:14 // CHECK-NEXT:[[CASTED_ALIGN:%.*]] = zext i32 [[TMP0]] to i64 // CHECK-NEXT:call void @llvm.assume(i1 true) [ "align"(i32* [[CALL]], i64 [[CASTED_ALIGN]]) ] // CHECK-NEXT:[[TMP1:%.

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 created this revision. Herald added a subscriber: jdoerfert. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM is growing knowledge of this, so we should inform it when we have the information available. Depends on D1182