[PATCH] D43667: [clang-doc] Implement a YAML generator

Athosvk added a comment. In https://reviews.llvm.org/D43667#1063049, @juliehockett wrote: > In https://reviews.llvm.org/D43667#1062746, @Athosvk wrote: > > > I'm a bit late on this, but I'd say that YAML is usually not a 'final' > > format. What would be the use-cases for this? And if is meant a

[PATCH] D43667: [clang-doc] Implement a YAML generator

Athosvk added a comment. I'm a bit late on this, but I'd say that YAML is usually not a 'final' format. What would be the use-cases for this? And if is meant as an alternative intermediate format, why not instead of having one big file, have one file per input file? Just wondering what the part

[PATCH] D43667: [clang-doc] Implement a YAML generator

Athosvk added a comment. I'm a bit late on this, but I'd say that YAML is usually not a 'final' format. What would be the use-cases for this? And if is meant as an alternative intermediate format, why not instead of having one big file, have one file per input file? Just wondering what the part

[PATCH] D41102: Setup clang-doc frontend framework

Athosvk added a comment. In https://reviews.llvm.org/D41102#1028760, @juliehockett wrote: > If you take a look at the follow-on patch to this (D43341 > ), you'll see that that is where the pointer > is added in (since it is irrelevant to the mapper portion, as i

[PATCH] D41102: Setup clang-doc frontend framework

Athosvk added a comment. My apologies for getting back on this so late! In https://reviews.llvm.org/D41102#1017683, @juliehockett wrote: > So, as an idea (as this diff implements), I updated the string references to > be a struct, which holds the USR of the referenced type (for serialization,

[PATCH] D41102: Setup clang-doc frontend framework

Athosvk added a comment. The change to USR seems like quite an improvement already! That being said, I do think that it might be preferable to opt out of the use of strings for linking things together. What we did with our clang-doc is that we directly used pointers to refer to other types. So

[PATCH] D41102: Setup clang-doc frontend framework

Athosvk added a comment. The changes seem good (both mapper and additional changes)! I've added some comments, but those are primarily details. What I'm however primarily interested in is the following: 1. You seemingly output only little information for declarations that are not definition. I

[PATCH] D41102: Setup clang-doc frontend framework

Athosvk added inline comments. Comment at: tools/clang-doc/ClangDocReporter.h:39 // Info for named types (parameters, members). struct NamedType { std::string Type; Storing the type information seems more suitable than storing just the name and type as a st

[PATCH] D41102: Setup clang-doc frontend framework

Athosvk added a comment. As we had discussed before, we're interested in the development as well! As an overall comment, I speak from experience that maintaining a large degree of documentation throughout the source code of the tool can provide an excellent test-case. We sure hope this will mo