[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

2021-04-06 Thread Asher Mancinelli via Phabricator via cfe-commits
ashermancinelli added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:127 + + auto &parseTree{*ci.parsing().parseTree()}; + Is this variable unused? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

2021-03-03 Thread Asher Mancinelli via Phabricator via cfe-commits
ashermancinelli added a comment. It //is// unintuitive to me that we are mixing feature and action flags, however I don't have a better suggestion. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97457/new/ https://reviews.llvm.org/D97457 ___