asudarsa wrote:
@bader
Can you please take a look when convenient?
Thanks
https://github.com/llvm/llvm-project/pull/133194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asudarsa approved this pull request.
LGTM. Minor nits. Thanks
https://github.com/llvm/llvm-project/pull/133194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -440,9 +570,15 @@ int main(int argc, char **argv) {
DryRun = Args.hasArg(OPT_dry_run);
SaveTemps = Args.hasArg(OPT_save_temps);
- OutputFile = "a.out";
- if (Args.hasArg(OPT_o))
-OutputFile = Args.getLastArgValue(OPT_o);
+ IsAOTCompileNeeded = IsIntelOffloadArch(
@@ -440,9 +570,15 @@ int main(int argc, char **argv) {
DryRun = Args.hasArg(OPT_dry_run);
SaveTemps = Args.hasArg(OPT_save_temps);
- OutputFile = "a.out";
- if (Args.hasArg(OPT_o))
-OutputFile = Args.getLastArgValue(OPT_o);
+ IsAOTCompileNeeded = IsIntelOffloadArch(
@@ -338,6 +382,87 @@ static Error runSPIRVCodeGen(StringRef File, const ArgList
&Args,
return Error::success();
}
+/// Run AOT compilation for Intel CPU.
+/// Calls opencl-aot tool to generate device code for Intel CPU backend.
+/// 'InputFile' is the input SPIR-V file.
+//
@@ -358,15 +483,20 @@ Error runSYCLLink(ArrayRef Files, const
ArgList &Args) {
SmallVector SplitModules;
SplitModules.emplace_back(*LinkedFile);
- // SPIR-V code generation step.
+ // SPIR-V code generation step and AOT compilation step.
asudarsa wrote:
@@ -46,3 +46,11 @@ def spirv_dump_device_code_EQ : Joined<["--", "-"],
"spirv-dump-device-code=">,
def print_linked_module : Flag<["--"], "print-linked-module">,
Flags<[LinkerOnlyOption]>,
HelpText<"Print the linked module's
https://github.com/asudarsa approved this pull request.
LGTM. Thanks
https://github.com/llvm/llvm-project/pull/137070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,143 @@
+//===--- OffloadArch.h - Definition of offloading architectures --- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/asudarsa converted_to_draft
https://github.com/llvm/llvm-project/pull/135683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/135683
>From a855d6dcff02209767582676012ef8a13897241f Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 14 Apr 2025 14:16:05 -0700
Subject: [PATCH 1/6] [SYCL] Add clang-linker-wrapper changes to call
clang-
asudarsa wrote:
> @sarnex I've landed
> [3133c95](https://github.com/llvm/llvm-project/commit/3133c956c57c5b952d3289323891dcdc252ea333)
> to fix a warning from this PR. Thanks!
Thanks so much.
https://github.com/llvm/llvm-project/pull/135683
___
cfe
@@ -792,6 +805,7 @@ bundleLinkedOutput(ArrayRef Images, const
ArgList &Args,
llvm::TimeTraceScope TimeScope("Bundle linked output");
switch (Kind) {
case OFK_OpenMP:
+ case OFK_SYCL:
return bundleOpenMP(Images);
asudarsa wrote:
Yes. Please. Thanks
@@ -792,6 +805,7 @@ bundleLinkedOutput(ArrayRef Images, const
ArgList &Args,
llvm::TimeTraceScope TimeScope("Bundle linked output");
switch (Kind) {
case OFK_OpenMP:
+ case OFK_SYCL:
return bundleOpenMP(Images);
asudarsa wrote:
Bundling logic is v
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/135683
>From 597fda606efbcf10304fed4adc5dd85da34b3de3 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 14 Apr 2025 14:16:05 -0700
Subject: [PATCH 1/5] [SYCL] Add clang-linker-wrapper changes to call
clang-
asudarsa wrote:
Hi @jhuber6
I added a constraint that Images of SYCL offloading kind cannot be linked with
images of other kind. This is a valid constraint in the current state of SYCL
upstreaming effort. We will aim to remove this constraint soon.
This makes the clang-linker-wrapper code ch
https://github.com/asudarsa ready_for_review
https://github.com/llvm/llvm-project/pull/135683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/135683
>From 597fda606efbcf10304fed4adc5dd85da34b3de3 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 14 Apr 2025 14:16:05 -0700
Subject: [PATCH 1/6] [SYCL] Add clang-linker-wrapper changes to call
clang-
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/135683
>From 597fda606efbcf10304fed4adc5dd85da34b3de3 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 14 Apr 2025 14:16:05 -0700
Subject: [PATCH 1/4] [SYCL] Add clang-linker-wrapper changes to call
clang-
asudarsa wrote:
Marking this as a draft to attempt refactoring of clang-linker-wrapper changes
based on offline discussions with @jhuber6
Thanks much
https://github.com/llvm/llvm-project/pull/135683
___
cfe-commits mailing list
cfe-commits@lists.llv
@@ -168,10 +170,10 @@ Expected> getInput(const ArgList
&Args) {
/// are LLVM IR bitcode files.
// TODO: Support SPIR-V IR files.
Expected> getBitcodeModule(StringRef File,
- LLVMContext &C) {
+
asudarsa wrote:
Hi @jhuber6
https://github.com/llvm/llvm-project/pull/135809 has been merged.
I have refactored this change on top of that.
Kindly take a look whenever convenient.
Sincerely
https://github.com/llvm/llvm-project/pull/135683
___
cfe-
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/135683
>From 597fda606efbcf10304fed4adc5dd85da34b3de3 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 14 Apr 2025 14:16:05 -0700
Subject: [PATCH 1/3] [SYCL] Add clang-linker-wrapper changes to call
clang-
asudarsa wrote:
AddressSanitizer test is passing in subsequent runs. Mostly a flaky issue.
Thanks
https://github.com/llvm/llvm-project/pull/135809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/135809
>From ec072a0ef5b699c58dd2ac404c90a5078f4a774a Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Tue, 15 Apr 2025 09:27:27 -0700
Subject: [PATCH 1/3] [Offload][SYCL] Refactor OffloadKind implementation
Si
@@ -32,10 +32,12 @@ namespace object {
/// The producer of the associated offloading image.
enum OffloadKind : uint16_t {
OFK_None = 0,
- OFK_OpenMP,
- OFK_Cuda,
- OFK_HIP,
- OFK_LAST,
+ OFK_OpenMP = (1 << 1),
asudarsa wrote:
Addressed in c0bc6890a68b7b
@@ -32,10 +32,12 @@ namespace object {
/// The producer of the associated offloading image.
enum OffloadKind : uint16_t {
OFK_None = 0,
- OFK_OpenMP,
- OFK_Cuda,
- OFK_HIP,
- OFK_LAST,
+ OFK_OpenMP = (1 << 1),
+ OFK_FIRST = OFK_OpenMP,
asudarsa wrote:
@@ -923,10 +923,9 @@ Expected> linkAndWrapDeviceFiles(
});
auto LinkerArgs = getLinkerArgs(Input, BaseArgs);
-DenseSet ActiveOffloadKinds;
+uint16_t ActiveOffloadKindMask = 0u;
asudarsa wrote:
I think it is a good optimization to have (16-
asudarsa wrote:
Hi @jhuber6
Thanks so much for feedback so far. I have added a separate PR
(https://github.com/llvm/llvm-project/pull/135809) for improving OffloadKind
implementation. Kindly take a look.
Thanks
https://github.com/llvm/llvm-project/pull/135683
___
https://github.com/asudarsa created
https://github.com/llvm/llvm-project/pull/135809
Following are the changes:
1. Make OffloadKind enum values to be powers of two so we can use them like a
bitfield
2. Include OFK_SYCL enum value
3. Modify ActiveOffloadKinds support in clang-linker-wrapper to
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/135683
>From 226d96d4e66e0a1e9d4f42df413d11a6ece4fec9 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 14 Apr 2025 14:16:05 -0700
Subject: [PATCH 1/2] [SYCL] Add clang-linker-wrapper changes to call
clang-
@@ -35,6 +35,7 @@ enum OffloadKind : uint16_t {
OFK_OpenMP,
OFK_Cuda,
OFK_HIP,
+ OFK_SYCL,
asudarsa wrote:
As proposed by @jhuber6 earlier, I will submit a separate PR to make changes to
offload kind representation.
And then update this PR after that g
@@ -464,7 +464,8 @@ fatbinary(ArrayRef>
InputFiles,
} // namespace amdgcn
namespace generic {
-Expected clang(ArrayRef InputFiles, const ArgList &Args)
{
+Expected clang(ArrayRef InputFiles, const ArgList &Args,
+ bool HasSYCLOffloadKind = false) {
-
@@ -35,6 +35,7 @@ enum OffloadKind : uint16_t {
OFK_OpenMP,
OFK_Cuda,
OFK_HIP,
+ OFK_SYCL,
asudarsa wrote:
As mentioned earlier
(https://github.com/llvm/llvm-project/pull/135683#discussion_r2043140354), it
might be better to address this change in a s
@@ -937,13 +961,47 @@ Expected> linkAndWrapDeviceFiles(
InputFiles.emplace_back(*FileNameOrErr);
}
+if (HasSYCLOffloadKind) {
+ // Link the remaining device files using the device linker.
+ auto OutputOrErr = linkDevice(InputFiles, LinkerArgs,
HasSYCLO
@@ -464,7 +464,8 @@ fatbinary(ArrayRef>
InputFiles,
} // namespace amdgcn
namespace generic {
-Expected clang(ArrayRef InputFiles, const ArgList &Args)
{
+Expected clang(ArrayRef InputFiles, const ArgList &Args,
+ bool HasSYCLOffloadKind = false) {
-
asudarsa wrote:
Hi @jhuber6
There are a couple of TODO comments in this PR:
1. Add sycl post link functionality (including device code splitting) - This PR
is under review here - https://github.com/llvm/llvm-project/pull/131347
2. Add SYCL offload wrapping logic - We are working on submitting
https://github.com/asudarsa created
https://github.com/llvm/llvm-project/pull/135683
Device code linking happens inside clang-linker-wrapper. In the current
implementation, clang-linker-wrapper does the following:
1. Extracts device code. Input_1, Input_2,.
2. Group device code according t
https://github.com/asudarsa edited
https://github.com/llvm/llvm-project/pull/135683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asudarsa wrote:
For the test failures, please resync with the tip of the repo and the test
failure should disappear.
https://github.com/llvm/llvm-project/pull/133194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -163,6 +220,15 @@ static inline bool IsAMDOffloadArch(OffloadArch A) {
return A >= OffloadArch::GFX600 && A < OffloadArch::Generic;
}
+static inline bool IsIntelCPUArch(OffloadArch Arch) {
asudarsa wrote:
For sake of completion, can you please add IsInte
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/133967
>From 0ab40315cd5ca320d84f87c99b8f23d9b6e8ed36 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 31 Mar 2025 14:31:24 -0700
Subject: [PATCH 1/6] [SYCL][SPIR-V Backend][clang-sycl-linker] Add SPIR-V
b
asudarsa wrote:
@sarnex, @jhuber6
Thanks much for your kind feedbacks. This is ready to be merged. Can one of you
please help?
Sincerely
https://github.com/llvm/llvm-project/pull/133967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/133967
>From 0ab40315cd5ca320d84f87c99b8f23d9b6e8ed36 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 31 Mar 2025 14:31:24 -0700
Subject: [PATCH 1/6] [SYCL][SPIR-V Backend][clang-sycl-linker] Add SPIR-V
b
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/133967
>From 0ab40315cd5ca320d84f87c99b8f23d9b6e8ed36 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 31 Mar 2025 14:31:24 -0700
Subject: [PATCH 1/5] [SYCL][SPIR-V Backend][clang-sycl-linker] Add SPIR-V
b
https://github.com/asudarsa created
https://github.com/llvm/llvm-project/pull/133797
This PR has the following changes:
Replace llvm-link with calls to linkInModule to link device files Add
-print-linked-module option to dump linked module for testing Added a test to
verify that linking is wo
https://github.com/asudarsa edited
https://github.com/llvm/llvm-project/pull/133776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asudarsa wrote:
Please remove redundant 'support' from PR topic
https://github.com/llvm/llvm-project/pull/133194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asudarsa wrote:
Hi @jhuber6
Just a quick ping to check if this PR is still alive. I can take a look if it
is.
Thanks
https://github.com/llvm/llvm-project/pull/125556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -7117,6 +7117,13 @@ void Clang::ConstructJob(Compilation &C, const JobAction
&JA,
}
}
+ // The offloading devices do not support RTTI.
asudarsa wrote:
I see that IsHIPDevice has been added to the check here (compared to what was
deleted inside Cod
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/133797
>From 675595e453b2452e49847ba3b949909367c7942a Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Mon, 31 Mar 2025 13:04:47 -0700
Subject: [PATCH 1/2] [clang-sycl-linker] Replace llvm-link with API calls
T
asudarsa wrote:
@jhuber6
Can you please take a look? This is one of the many changes we are making to
upstream SYCL.
Thanks
https://github.com/llvm/llvm-project/pull/133797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
asudarsa wrote:
> Shouldn't we be able to just use LTO after the SPIR-V backend left
> experimental?
Hi @jhuber6
Thanks for the ping back. That is the eventual path for us. However, we would
like to do it in stages. Replacing llvm-link tool with linkInModule call helps
us to achieve one of
asudarsa wrote:
> > > @farzonl can you please revert the original commit? It seems to break
> > > just any LLVM build, so I guess the CI testing of all new PRs should be
> > > affected.
> >
> >
> > I don't see it breaking any build in LLVM, just the amd offload ones. Al
> > the Premerge test
https://github.com/asudarsa commented:
I tried to build it locally and I got a series of 'undefined reference' errors.
Sorry, I will need to revert my approval.
Thanks
https://github.com/llvm/llvm-project/pull/133776
___
cfe-commits mailing list
cfe-
https://github.com/asudarsa approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/133776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asudarsa closed
https://github.com/llvm/llvm-project/pull/129973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asudarsa approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/129545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -78,7 +77,7 @@ class LLVM_LIBRARY_VISIBILITY SPIRVToolChain : public
ToolChain {
bool useIntegratedAs() const override { return true; }
- bool IsIntegratedBackendDefault() const override { return false; }
+ bool IsIntegratedBackendDefault() const override { return tru
asudarsa wrote:
Sanitizer test failures should be resolved by
https://github.com/llvm/llvm-project/pull/114488 (under review).
Thanks to @sarnex for the timely fix.
Sincerely
https://github.com/llvm/llvm-project/pull/112245
___
cfe-commits mailing li
asudarsa wrote:
This is not the correct fix. Closing it.
Thanks
https://github.com/llvm/llvm-project/pull/114434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asudarsa closed
https://github.com/llvm/llvm-project/pull/114434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asudarsa created
https://github.com/llvm/llvm-project/pull/114434
None
>From 9cfc10768adf19e41b22cd6a9fb2c781fdf4498e Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Thu, 31 Oct 2024 10:34:06 -0700
Subject: [PATCH] Initialize SmallVector variable
Signed-off-by: Arvin
asudarsa wrote:
All the failures seem to be related to missing dependencies. I am working on a
fix. Thanks
https://github.com/llvm/llvm-project/pull/112245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
@@ -0,0 +1,48 @@
+// Tests the clang-sycl-linker tool.
+//
+// Test a simple case without arguments.
+// RUN: %clangxx -emit-llvm -c %s -o %t_1.bc
+// RUN: %clangxx -emit-llvm -c %s -o %t_2.bc
+// RUN: clang-sycl-linker --dry-run -triple spirv64 %t_1.bc %t_2.bc -o a.spv
2>&1 \
+/
@@ -0,0 +1,42 @@
+// Tests the clang-sycl-linker tool.
+//
+// Test a simple case without arguments.
+// RUN: %clangxx -fsycl -emit-llvm -c %s -o %t.bc
+// RUN: clang-sycl-linker --dry-run -triple spirv64 %t.bc -o a.spv 2>&1 \
+// RUN: | FileCheck %s --check-prefix=SIMPLE
+// SI
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/112245
>From eff4a0300336c4c106e1d293b19e795f5ccbabc1 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Fri, 27 Sep 2024 13:03:12 -0700
Subject: [PATCH 01/12] [Clang][SYCL] Introduce clang-sycl-link-wrapper to li
asudarsa wrote:
Hi @bader
Thanks very much for your feedback. I have addressed the concerns in the latest
commit.
Thanks to @jhuber6 for some responses as well.
Sincerely
https://github.com/llvm/llvm-project/pull/112245
___
cfe-commits mailing list
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/112245
>From eff4a0300336c4c106e1d293b19e795f5ccbabc1 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Fri, 27 Sep 2024 13:03:12 -0700
Subject: [PATCH 01/11] [Clang][SYCL] Introduce clang-sycl-link-wrapper to li
@@ -0,0 +1,500 @@
+//= clang-sycl-linker/ClangSYCLLinker.cpp - SYCL Linker util ---=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,13 @@
+// Tests the driver when linking LLVM IR bitcode files and targeting SPIR-V
+// architecture.
+//
+// RUN: touch %t.bc
+// RUN: %clangxx --target=spirv64 --sycl-link -### %t.bc 2>&1 \
+// RUN: | FileCheck %s -check-prefix=LINK
+// LINK: "{{.*}}clang-sycl-linker
@@ -0,0 +1,42 @@
+// Tests the clang-sycl-linker tool.
+//
+// Test a simple case without arguments.
+// RUN: %clangxx -fsycl -emit-llvm -c %s -o %t.bc
+// RUN: clang-sycl-linker --dry-run -triple spirv64 %t.bc -o a.spv 2>&1 \
+// RUN: | FileCheck %s --check-prefix=SIMPLE
+// SI
@@ -0,0 +1,13 @@
+// Tests the driver when linking LLVM IR bitcode files and targeting SPIR-V
+// architecture.
+//
+// RUN: touch %t.bc
+// RUN: %clangxx --target=spirv64 --sycl-link -### %t.bc 2>&1 \
+// RUN: | FileCheck %s -check-prefix=LINK
+// LINK: "{{.*}}clang-sycl-linker
@@ -0,0 +1,55 @@
+include "llvm/Option/OptParser.td"
+
+def WrapperOnlyOption : OptionFlag;
+
+def help : Flag<["-", "--"], "help">,
+ HelpText<"Display available options (--help-hidden for more)">;
+
+def help_hidden : Flag<["-", "--"], "help-hidden">,
+ HelpText<"Display all a
@@ -0,0 +1,55 @@
+include "llvm/Option/OptParser.td"
+
+def WrapperOnlyOption : OptionFlag;
+
+def help : Flag<["-", "--"], "help">,
+ HelpText<"Display available options (--help-hidden for more)">;
+
+def help_hidden : Flag<["-", "--"], "help-hidden">,
+ HelpText<"Display all a
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/113613
>From 5b890e60ad8c349254d687e96452a8f575e5 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Thu, 24 Oct 2024 12:46:18 -0700
Subject: [PATCH 1/2] [clang-linker-wrapper] Add error handling for missing
asudarsa wrote:
@jhuber6
Can you please take a look and comment if this change looks ok.
Thanks
https://github.com/llvm/llvm-project/pull/113613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -370,6 +370,8 @@ Error runLinker(ArrayRef Files, const ArgList
&Args) {
// Render the linker arguments and add the newly created image. We add it
// after the output file to ensure it is linked with the correct libraries.
StringRef LinkerPath = Args.getLastArgValue(OP
https://github.com/asudarsa created
https://github.com/llvm/llvm-project/pull/113613
In clang-linker-wrapper, we do not explicitly check if --linker-path is
provided.
This PR adds a check to capture this.
Thanks
>From 5b890e60ad8c349254d687e96452a8f575e5 Mon Sep 17 00:00:00 2001
From: Arv
asudarsa wrote:
@bader, thanks for adding the SYCL label. Can you please provide your feedback
for this PR when convenient? For some reason, I am not able to add reviewers.
Thanks
https://github.com/llvm/llvm-project/pull/112245
___
cfe-commits maili
asudarsa wrote:
Hi @llvm-beanz
Thanks so much for providing your valuable time and feedback thus far. I have
addressed the concerns raised to the best of my ability. I have added more
testing inside 'clang/test/Driver/clang-sycl-linker-test.cpp'. It will be great
if you can take another look
https://github.com/asudarsa edited
https://github.com/llvm/llvm-project/pull/112245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asudarsa wrote:
clang/test/Driver is not the correct place to be testing for tool availability.
Thanks
https://github.com/llvm/llvm-project/pull/112245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/112245
>From eff4a0300336c4c106e1d293b19e795f5ccbabc1 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Fri, 27 Sep 2024 13:03:12 -0700
Subject: [PATCH 01/10] [Clang][SYCL] Introduce clang-sycl-link-wrapper to li
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/112245
>From eff4a0300336c4c106e1d293b19e795f5ccbabc1 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Fri, 27 Sep 2024 13:03:12 -0700
Subject: [PATCH 1/9] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link
asudarsa wrote:
> At a minimum I think this change needs more tests. There's a lot of code
> added with very minimal test coverage.
>
> I'm uncomfortable with adding a design that is effectively a workaround with
> an unwritten "TODO" to fix it up later, but I also don't want to needlessly
>
asudarsa wrote:
Hi @llvm-beanz and @jhuber6
Thanks so much for all the feedback and discussion here. I am very much
grateful for both your time and insights here. I will try to give my answers in
this comment.
An overview of the SYCL compilation flow (with a bit more emphasis on the
device c
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/112245
>From eff4a0300336c4c106e1d293b19e795f5ccbabc1 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Fri, 27 Sep 2024 13:03:12 -0700
Subject: [PATCH 1/8] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/112245
>From eff4a0300336c4c106e1d293b19e795f5ccbabc1 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Fri, 27 Sep 2024 13:03:12 -0700
Subject: [PATCH 1/7] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link
asudarsa wrote:
Hi @jhuber6
I have addressed all the concerns to my best ability. Thanks very much for your
guidance and feedback thus far.
Thanks
Sincerely
https://github.com/llvm/llvm-project/pull/112245
___
cfe-commits mailing list
cfe-commits@l
@@ -0,0 +1,528 @@
+//=-- clang-sycl-link-wrapper/ClangSYCLLinkWrapper.cpp - SYCL linker util --=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,528 @@
+//=-- clang-sycl-link-wrapper/ClangSYCLLinkWrapper.cpp - SYCL linker util --=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
asudarsa wrote:
Modified the test to just use empty files. Change can be found in
307c74ea4f910a7698a6084db710ff7b699c5c93
Thanks
https://github.com/llvm/llvm-project/pull/112245
___
cfe-commits mailing list
cfe-com
@@ -95,7 +95,19 @@ void SPIRV::Linker::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back("-o");
CmdArgs.push_back(Output.getFilename());
+ // Use of --sycl-link will call the clang-sycl-link-wrapper instead of
+ // the default linker (spirv-link).
+ i
asudarsa wrote:
Earlier test fail due to lack of new tool in clang/test/lit.cfg.py.
Added it now.
Thanks
https://github.com/llvm/llvm-project/pull/112245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/112245
>From eff4a0300336c4c106e1d293b19e795f5ccbabc1 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Fri, 27 Sep 2024 13:03:12 -0700
Subject: [PATCH 1/5] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link
https://github.com/asudarsa updated
https://github.com/llvm/llvm-project/pull/112245
>From eff4a0300336c4c106e1d293b19e795f5ccbabc1 Mon Sep 17 00:00:00 2001
From: Arvind Sudarsanam
Date: Fri, 27 Sep 2024 13:03:12 -0700
Subject: [PATCH 1/4] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link
https://github.com/asudarsa edited
https://github.com/llvm/llvm-project/pull/112245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -95,7 +95,19 @@ void SPIRV::Linker::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back("-o");
CmdArgs.push_back(Output.getFilename());
+ // Use of --sycl-link will call the clang-sycl-link-wrapper instead of
+ // the default linker (spirv-link).
+ i
@@ -6728,7 +6728,10 @@ def fsycl : Flag<["-"], "fsycl">,
def fno_sycl : Flag<["-"], "fno-sycl">,
Visibility<[ClangOption, CLOption]>,
Group, HelpText<"Disables SYCL kernels compilation for device">;
-
+def sycl_link : Flag<["--"], "sycl-link">, Flags<[HelpHidden]>,
1 - 100 of 118 matches
Mail list logo
