[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

MasterAwesome wrote: > > > > @erichkeane @AaronBallman, I've added the release notes and rebased the > > > > change on `main`. Does this need to be backported to 17.x? 16.x doesn't > > > > have this issue > > > > > > > > > Yeah, I think we should probably backport this to 17.x. We have > > >

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

MasterAwesome wrote: > > @erichkeane @AaronBallman, I've added the release notes and rebased the > > change on `main`. Does this need to be backported to 17.x? 16.x doesn't > > have this issue > > Yeah, I think we should probably backport this to 17.x. We have instructions > on how to kick th

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

MasterAwesome wrote: @AaronBallman, @erichkeane; whenever ya'll are done with the review, can you merge this in? I don't think I have access. And about the backporting, do we need it for 17.x bugfix releases? https://github.com/llvm/llvm-project/pull/68284 _

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

@@ -343,6 +343,8 @@ Bug Fixes in This Version - Fix a crash when evaluating value-dependent structured binding variables at compile time. Fixes (`#67690 `_) +- Fixes a regression where ``LLVM_UNREACHABLE_OPTIMIZE=OFF`` cann

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/MasterAwesome updated https://github.com/llvm/llvm-project/pull/68284 >From 8598d5f4cfad4f3887ec40b7c3d21e385f731d9d Mon Sep 17 00:00:00 2001 From: Arvind Mukund Date: Wed, 4 Oct 2023 22:25:08 -0700 Subject: [PATCH 1/4] Correct unreachable hint in release mode When LLVM_UNRE

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

MasterAwesome wrote: @erichkeane @AaronBallman, I've added the release notes and rebased the change on `main`. https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/MasterAwesome updated https://github.com/llvm/llvm-project/pull/68284 >From 8598d5f4cfad4f3887ec40b7c3d21e385f731d9d Mon Sep 17 00:00:00 2001 From: Arvind Mukund Date: Wed, 4 Oct 2023 22:25:08 -0700 Subject: [PATCH 1/3] Correct unreachable hint in release mode When LLVM_UNRE

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/MasterAwesome edited https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/MasterAwesome ready_for_review https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/MasterAwesome edited https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/MasterAwesome updated https://github.com/llvm/llvm-project/pull/68284 >From edb04da9e4db6043f0905ad887a1fe5ffad48fca Mon Sep 17 00:00:00 2001 From: Arvind Mukund Date: Wed, 4 Oct 2023 22:25:08 -0700 Subject: [PATCH 1/2] Correct unreachable hint in release mode When LLVM_UNRE

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/MasterAwesome edited https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/MasterAwesome edited https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/MasterAwesome created https://github.com/llvm/llvm-project/pull/68284 When LLVM_UNREACHABLE_OPTIMIZE is turned off during release mode, a `do { BUILTIN_TRAP; BUILTIN_UNREACHABLE; } while(0)` is emitted this causes the ternary operator to not work as expected. Correct this be