[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo added a comment. In D136355#3875265 , @aaron.ballman wrote: > LGTM aside from a tiny grammar nit. Thank you for the fix! If you'd like me > to commit this on your behalf, I can fix up the release note myself when > landing, but please let me kno

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo updated this revision to Diff 469605. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136355/new/ https://reviews.llvm.org/D136355 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp clang/test/Sema/non-null-warning.c Index: clang/test/Sema/non-null-warning.c

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo updated this revision to Diff 469604. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136355/new/ https://reviews.llvm.org/D136355 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp clang/test/Sema/non-null-warning.c Index: clang/test/Sema/non-null-warning.c

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo updated this revision to Diff 469571. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136355/new/ https://reviews.llvm.org/D136355 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp clang/test/Sema/non-null-warning.c Index: clang/test/Sema/non-null-warning.c

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo updated this revision to Diff 469559. Grillo added a comment. Add test coverage and release note about the fix to `clang/docs/ReleaseNotes.rst` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136355/new/ https://reviews.llvm.org/D136355 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

Grillo created this revision. Grillo added a reviewer: aaron.ballman. Herald added a project: All. Grillo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When checking for non null arguments the wrong SourceLocation was given, this fix to p