[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1787 +if (!VCI->isMinSignedValue()) { + return EmitAbs(CGF, ArgValue, true); +} MaskRay wrote: > MaskRay wrote: > > nit: we delete braces in this cascading case > > > > https:/

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem updated this revision to Diff 551966. artem marked an inline comment as done. artem added a comment. Rebased and fixed legacy FileCheck syntax. Gentle reminder that I do not have commit rights. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D15

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added inline comments. Comment at: clang/test/ubsan/TestCases/Misc/abs.cpp:1 +// REQUIRES: arch=x86_64 +// MaskRay wrote: > Did you mean compiler-rt/ instead of clang/? > > `// REQUIRES: arch=x86_64` is legacy style. > > New style uses `// REQUIRES: targe

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem updated this revision to Diff 551656. artem marked 2 inline comments as done. artem added a comment. Fixed the comments. I do not have commit rights CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added a comment. Thanks for the review. I do not have commit rights, could you please push it? Artem Labazov <123321art...@gmail.com> CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 ___ cfe-c

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem updated this revision to Diff 550013. artem marked 5 inline comments as done. artem edited the summary of this revision. artem added a comment. Fixed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 Files: clang/docs/Rel

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added a comment. Thanks for the feedback! I will resolve the problems in the next revision after some clarifications. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2697 +bool SanitizeBuiltin = SanOpts.has(SanitizerKind::Builtin); +bool SanitizeOverflow = SanOpts.ha

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem updated this revision to Diff 546269. artem added a comment. typo fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CodeGenFunction.h clang/test/CodeGen/PowerPC/builtins-pp

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem updated this revision to Diff 546261. artem added a comment. Fixed comments and failing test. Added a new compiler-rt test for ubsan CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Cod

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem created this revision. artem added a reviewer: craig.topper. Herald added subscribers: Enna1, kbarton, nemanjai. Herald added a project: All. artem requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Currenly both Cl