[PATCH] D140176: [clang][deps] NFC: Split out the module-based API from the TU-based API

2022-12-16 Thread Artem Chikin via Phabricator via cfe-commits
artemcm accepted this revision. artemcm added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:111 + /// information needed for explicit build. + llvm::Expected + getModuleDep

[PATCH] D140175: [clang][deps] Remove support for the deprecated driver API

2022-12-16 Thread Artem Chikin via Phabricator via cfe-commits
artemcm accepted this revision. artemcm added a comment. This revision is now accepted and ready to land. Swift has moved away from this kind of API. I can't speak for other clients, but this LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1401

[PATCH] D140176: [clang][deps] NFC: Split out the module-based API from the TU-based API

2022-12-16 Thread Artem Chikin via Phabricator via cfe-commits
artemcm requested changes to this revision. artemcm added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:111 + /// information needed for explicit build. + llvm::Expected + ge

[PATCH] D97702: [clang][modules] Use extensible RTTI for ModuleFileExtension

2021-03-04 Thread Artem Chikin via Phabricator via cfe-commits
artemcm accepted this revision. artemcm added a comment. This revision is now accepted and ready to land. This looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97702/new/ https://reviews.llvm.org/D97702 _