artemcm accepted this revision.
artemcm added inline comments.
This revision is now accepted and ready to land.
Comment at:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:111
+ /// information needed for explicit build.
+ llvm::Expected
+ getModuleDep
artemcm accepted this revision.
artemcm added a comment.
This revision is now accepted and ready to land.
Swift has moved away from this kind of API. I can't speak for other clients,
but this LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1401
artemcm requested changes to this revision.
artemcm added inline comments.
This revision now requires changes to proceed.
Comment at:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:111
+ /// information needed for explicit build.
+ llvm::Expected
+ ge
artemcm accepted this revision.
artemcm added a comment.
This revision is now accepted and ready to land.
This looks good to me, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97702/new/
https://reviews.llvm.org/D97702
_