zeux wrote:
Confirming this fixes the original problem on the larger codebase, thanks!
https://github.com/llvm/llvm-project/pull/107257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zeux wrote:
Here's a slightly smaller reproducer that just reads one element from the
array. Similarly, this crashes because the compiler generates a load from an
absolute `-1` address. The crash is after the first `printf` call in this case
during the computation of the argument to the second
zeux wrote:
This change leads to a miscompilation; I've extracted a somewhat minimal repro
case from the referenced issue above, in the comment:
https://github.com/zeux/pugixml/issues/629#issuecomment-2346839855
The code, when compiled with `-O2 -g` by latest clang on Linux/X64, generates
the
zeux wrote:
Let me know if I need to do anything else here -- I don't have commit rights so
someone else will need to press the merge button :)
https://github.com/llvm/llvm-project/pull/69126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
zeux wrote:
Thanks! I've updated this PR with a release note.
https://github.com/llvm/llvm-project/pull/69126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zeux wrote:
Thanks! I've updated this PR with a release note.
https://github.com/llvm/llvm-project/pull/69126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zeux updated https://github.com/llvm/llvm-project/pull/69126
>From 357a21c38c1036a012affc85026fcba376ab7128 Mon Sep 17 00:00:00 2001
From: Arseny Kapoulkine
Date: Sun, 15 Oct 2023 13:20:31 -0700
Subject: [PATCH 1/2] [Sema] -Wzero-as-null-pointer-constant: don't warn for
__nul
zeux wrote:
Ping
https://github.com/llvm/llvm-project/pull/69126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zeux wrote:
Note: a limitation of this change is that we will still warn on use of `NULL`
when it is defined as 0, which could be a problem for clang-cl. This could be
lifted by removing the "NULL" macro name check, but unfortunately that is
insufficient to detect the use of NULL inside macro
https://github.com/zeux created https://github.com/llvm/llvm-project/pull/69126
The implementation of -Wzero-as-null-pointer-constant was done before the
following fix has been committed to GCC:
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=752e7593b0f19af233a0b7e72daab8413662b605;hp=298434
arseny.kapoulkine added a comment.
Ping.
http://reviews.llvm.org/D13192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arseny.kapoulkine created this revision.
arseny.kapoulkine added a subscriber: cfe-commits.
For nested functions, local-name can be followed by function arguments; in
some cases the first argument starts with a digit (if it's a named type).
For example, this code:
void test() { struct g { void f
12 matches
Mail list logo