Re: [PATCH] D12400: Fix store detection for return value in CGCall

2015-09-07 Thread Arnaud de Grandmaison via cfe-commits
aadg accepted this revision. aadg added a reviewer: aadg. aadg added a comment. This revision is now accepted and ready to land. This looks ok to me. Repository: rL LLVM http://reviews.llvm.org/D12400 ___ cfe-commits mailing list cfe-commits@list

Re: [PATCH] D12400: Fix store detection for return value in CGCall

2015-09-02 Thread Arnaud de Grandmaison via cfe-commits
aadg added a comment. Yet another comment (see below). Comment at: lib/CodeGen/CGCall.cpp:2332 @@ -2331,2 +2331,3 @@ if (!store) return nullptr; + if (store->getPointerOperand() != CGF.ReturnValue) return nullptr; aadg wrote: > It might be worth stating in

Re: [PATCH] D12400: Fix store detection for return value in CGCall

2015-09-02 Thread Arnaud de Grandmaison via cfe-commits
aadg added a subscriber: aadg. aadg added a comment. Just a minor nitpick (see below) Comment at: lib/CodeGen/CGCall.cpp:2332 @@ -2331,2 +2331,3 @@ if (!store) return nullptr; + if (store->getPointerOperand() != CGF.ReturnValue) return nullptr; It might be