[PATCH] D50410: Removing -debug-info-macros from option suggestions test

acoomans added a comment. @mattd thanks for confirming. I tried `clang -cc1as -target x86_64-scei-ps4 -debug-info-macros` and got suggestions. @modocache @mattd Should we try to first land https://reviews.llvm.org/D50515 to see if it fails again? Repository: rC Clang https://reviews.llvm.o

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

acoomans added subscribers: mattd, Sunil_Srivastava. acoomans added a comment. @mattd @Sunil_Srivastava if you have access to the PS4 SDK, could you tell if the `-debug-info-macro` command line clang option is available? Thank you Repository: rC Clang https://reviews.llvm.org/D50410 _

[PATCH] D50535: Fix selective formatting of ObjC scope

acoomans added a comment. @jolesiak let me know what you think Repository: rC Clang https://reviews.llvm.org/D50535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

acoomans added a comment. Can anyone confirm the `-debug-info-macro` command line option is unavailable with the PS4 SDK? Repository: rC Clang https://reviews.llvm.org/D50410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D50467: [SEMA] add more -Wfloat-conversion to compound assigment analysis

acoomans accepted this revision. acoomans added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D50467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D50535: Fix selective formatting of ObjC scope

acoomans added a comment. I probably don't need a unit test AND a lit test, but I'm unsure which one is best here. Any suggestion? Comment at: lib/Format/UnwrappedLineFormatter.cpp:1045-1047 +if (TheLine.First->Next && TheLine.First->Next->Tok.isObjCAtKeyword(tok::objc_en

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

acoomans abandoned this revision. acoomans added a comment. Changed approach based on feedback. New changeset: https://reviews.llvm.org/D50535 https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D50535: Fix selective formatting of ObjC scope

acoomans created this revision. acoomans added a reviewer: cfe-commits. ObjC scopes gets formatted beyond the `@end` directive, when formatting specific lines (`clang-format -lines=x:x`). This changeset fixes formatting of `@end` the same way that `r_braces` are. Repository: rC Clang https:

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

acoomans created this revision. acoomans added a reviewer: cfe-commits. Original changeset (https://reviews.llvm.org/D46776) by @modocache. It was reverted after the PS4 bot failed. The issue has been determined to be with the way the PS4 SDK handles this particular option. https://reviews.llvm

[PATCH] D49549: Change 'clang-test' to 'check-clang' on the hacking webpage

acoomans added a comment. @JDevlieghere Thanks! subscribers -> makes sense, will do Repository: rC Clang https://reviews.llvm.org/D49549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D49549: Change 'clang-test' to 'check-clang' on the hacking webpage

acoomans added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D49549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

acoomans added a subscriber: probinson. acoomans added a comment. @probinson does this sound a plausible explanation? Do you have access to a PS4 SDK to confirm the `-debug-info-macro` isn't available at all? Repository: rC Clang https://reviews.llvm.org/D50410 ___

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

acoomans created this revision. acoomans added reviewers: cfe-commits, modocache. Herald added subscribers: dexonsmith, JDevlieghere, mehdi_amini. https://reviews.llvm.org/D46776 added support for "did you mean ...?" command line option suggestions. One of the tests was checking against the `-de

[PATCH] D50147: clang-format: support external styles

acoomans added a comment. Doesn’t clang-format support project-based //.clang-format// or //_clang-format//? How do they play with this diff? Repository: rC Clang https://reviews.llvm.org/D50147 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

acoomans added a comment. I don't know; I just picked a random bug from the Bugzilla to get myself familiarized with the LLVM codebase :) @jolesiak? https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

acoomans added a comment. Also ping @jolesiak since he initially filed the report https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

acoomans added a comment. @djasper I updated the description of the diff. This fixes the issue of `clang-format -lines=x:x` not returning the same results as `clang-format`, while keeping the current behavior as default. https://reviews.llvm.org/D49580 __

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

acoomans updated this revision to Diff 156571. acoomans retitled this revision from "[WIP] Change clang-format to absolute indentation" to "[clang-format] Adding style option for absolute formatting". acoomans edited the summary of this revision. https://reviews.llvm.org/D49580 Files: docs/Cla

[PATCH] D49580: [WIP] Change clang-format to absolute indentation

acoomans added a comment. An alternative to changing the whole behavior would be to make it a parameter / configuration option. Repository: rC Clang https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D49580: [WIP] Change clang-format to absolute indentation

acoomans created this revision. Herald added a subscriber: cfe-commits. When running clang-format on specific lines, two types of indentation could be expectedi: - absolute indentation: the indentation one would get if the whole file were formatted; or - relative indentation: keep the indentati

[PATCH] D49549: Change 'clang-test' to 'check-clang' on the hacking webpage

acoomans created this revision. acoomans added reviewers: chandlerc, cfe-commits. The command to run tests was previously changed from 'clang-test' to 'check-clang'; with 'clang-test' remaining available as a legacy alias (see git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@159483 91177