[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

2023-09-05 Thread Arkadiy Yudintsev via Phabricator via cfe-commits
d0nc1h0t added a comment. In D158363#463 , @owenpan wrote: > We need the name and email you want to use in order to commit the patch for > you. Arkadiy Yudintsev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

2023-09-01 Thread Arkadiy Yudintsev via Phabricator via cfe-commits
d0nc1h0t added a comment. In D158363#4632451 , @owenpan wrote: > Do you need us to commit it for you? See > https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator. 'git push' or 'arc land' give an error 'remote: Permission t

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

2023-09-01 Thread Arkadiy Yudintsev via Phabricator via cfe-commits
d0nc1h0t updated this revision to Diff 555317. d0nc1h0t added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittests/Forma

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

2023-08-24 Thread Arkadiy Yudintsev via Phabricator via cfe-commits
d0nc1h0t marked an inline comment as done. d0nc1h0t added a comment. Fixed. (Relied on auto-formatting in the IDE) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 _

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

2023-08-24 Thread Arkadiy Yudintsev via Phabricator via cfe-commits
d0nc1h0t updated this revision to Diff 553085. d0nc1h0t added a comment. Added missing const + clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files: clang/lib/Format/UnwrappedLineFormatte

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

2023-08-24 Thread Arkadiy Yudintsev via Phabricator via cfe-commits
d0nc1h0t updated this revision to Diff 553017. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittests/Format/FormatTest.cpp Index: clang/uni

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

2023-08-22 Thread Arkadiy Yudintsev via Phabricator via cfe-commits
d0nc1h0t updated this revision to Diff 552604. d0nc1h0t added a comment. Updated the patch with full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files: clang/lib/Format/UnwrappedLineFormatt

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

2023-08-22 Thread Arkadiy Yudintsev via Phabricator via cfe-commits
d0nc1h0t added a comment. In D158363#4604468 , @HazardyKnusperkeks wrote: > Please upload the patch with the full context. I'm creating a patch via 'git diff' from the root of the project. What does full context mean? Repository: rG LLVM Github Mon

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

2023-08-22 Thread Arkadiy Yudintsev via Phabricator via cfe-commits
d0nc1h0t updated this revision to Diff 552281. d0nc1h0t added a comment. Added unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unitte

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

2023-08-20 Thread Arkadiy Yudintsev via Phabricator via cfe-commits
d0nc1h0t created this revision. d0nc1h0t added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a comment. d0nc1h0t requested review of this revision. NOTE: