[PATCH] D142048: [Phabricator] Fix __ptr32 arguments passed to builtins

Ariel-Burton updated this revision to Diff 490569. Ariel-Burton added a comment. - Adjust formatting to conform to git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142048/new/ https://reviews.llvm.org/D142048 Files: clang/lib/Sema/

[PATCH] D142048: [Phabricator] Fix __ptr32 arguments passed to builtins

Ariel-Burton created this revision. Herald added subscribers: arichardson, Anastasia. Herald added a project: All. Ariel-Burton requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently when clang deals with a call to a builtin function tha

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton updated this revision to Diff 450982. Ariel-Burton added a comment. - Add case to deal with ElaboratedTypes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 Files: clang/lib/Sema/SemaType.c

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added a comment. In D130123#3700174 , @rnk wrote: > In D130123#3698399 , @Ariel-Burton > wrote: > >> Just to make sure that we're on the same page, you'd like to see a test >> that confirms that cl

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton updated this revision to Diff 450157. Ariel-Burton added a comment. Recover original changes, and commit with new C++ __ptr32 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 Files: cl

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton updated this revision to Diff 450153. Ariel-Burton added a comment. Added C++ tests for __ptr32. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 Files: clang/test/Sema/MicrosoftExtensions.c

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added a comment. In D130123#3696786 , @rnk wrote: > In D130123#3696752 , @Ariel-Burton > wrote: > >> What is your expectation for your template code fragment? MSVC does not >> accept it. > > Yes, I

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added a comment. In D130123#3691011 , @rnk wrote: > That sounds reasonable to me, I confirmed that MSVC really only lets you > apply these attributes directly to pointer types and to typedefs. > > Can you add a test for the other most common

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7116 + for (;;) { +if (const TypedefType *TT = dyn_cast(Desugared)) { + Desugared = TT->desugar(); rnk wrote: > Ariel-Burton wrote: > > rnk wrote: > > > This seems like a good p

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7116 + for (;;) { +if (const TypedefType *TT = dyn_cast(Desugared)) { + Desugared = TT->desugar(); rnk wrote: > This seems like a good place to use getSingleStepDesugaredType to

[PATCH] D130123: [Phabricator] extend ptr32 support to be applied on typedef

Ariel-Burton created this revision. Ariel-Burton added reviewers: akhuang, rnk, rsmith. Herald added a project: All. Ariel-Burton requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Earlier, if the QualType was sugared, then we would error out