[PATCH] D155716: [clang][CodeGen] Introduce `-frecord-command-line` for MachO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2dea969d8337: [clang][CodeGen] Introduce `-frecord-command-line` for MachO (authored by antoniofrighetto). Repository: rG LLVM Github Monorepo CH

[PATCH] D155716: [clang][CodeGen] Introduce `-frecord-command-line` for MachO

antoniofrighetto added a comment. Thanks a lot for the reviews and for pointing out clang tests as well, there was a minor update to do there too! Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1424 +MCSection *TargetLoweringObjectFileMachO::getSectionForCommand

[PATCH] D155716: [clang][CodeGen] Introduce `-frecord-command-line` for MachO

antoniofrighetto updated this revision to Diff 542483. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155716/new/ https://reviews.llvm.org/D155716 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/clang_f_opts.c llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h

[PATCH] D155716: [clang][CodeGen] Introduce `-frecord-command-line` for MachO

antoniofrighetto created this revision. antoniofrighetto added reviewers: davide, ab, scott.linder. Herald added a subscriber: hiraditya. Herald added a project: All. antoniofrighetto requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added proje

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto added a comment. Awesome, thank you for reviewing this! PS: I do not have commit access, feel free to close it, if you say. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 ___ cfe-c

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto added inline comments. Comment at: llvm/unittests/ADT/STLExtrasTest.cpp:994 + enum A { Zero = 0, One = 1 }; + enum B { IntMax = INT_MAX, ULongLongMax = ULLONG_MAX }; + enum class C : unsigned { Two = 2 }; aaron.ballman wrote: > It looks like y

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto updated this revision to Diff 42. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 Files: clang/include/clang/AST/DeclarationName.h llvm/include/llvm/ADT/STLExtras.h llvm/unittests/ADT/STLExtrasTest.cpp Index: llvm/uni

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto updated this revision to Diff 420957. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 Files: clang/include/clang/AST/DeclarationName.h llvm/include/llvm/ADT/STLExtras.h llvm/unittests/ADT/STLExtrasTest.cpp Index: llvm/uni

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto added a comment. Fixed the change, and added a new test. Hope the coverage is at a fairly good level now! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 ___ cfe-commits mailing lis

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto updated this revision to Diff 420894. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 Files: clang/include/clang/AST/DeclarationName.h llvm/include/llvm/ADT/STLExtras.h llvm/unittests/ADT/STLExtrasTest.cpp Index: llvm/uni

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto updated this revision to Diff 420458. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 Files: clang/include/clang/AST/DeclarationName.h llvm/in

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto added a comment. Looks definitely better! How about this slightly changed version protecting the interface? /// Helper which adds two underlying types of enumeration type. template , std::underlying_type_t>, typename UT2 = std::enable_if_t, std::underlying_type

[PATCH] D122808: [clang] Fix warnings with `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto created this revision. antoniofrighetto added reviewers: aaron.ballman, dblaikie. antoniofrighetto added a project: clang. Herald added a project: All. antoniofrighetto requested review of this revision. Herald added a subscriber: cfe-commits. clang may throw the following warning