[PATCH] D85917: [MSP430] Fix passing C structs and unions as function arguments

asl added a comment. In D85917#4523503 , @arsenm wrote: > Is there a reason this never landed? Good question. @atrosinenko ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85917/new/ https://reviews.llvm.or

[PATCH] D116351: Update Bug report URL to Github Issues

asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Will you please check the comments and reword everything using proper terminology and new things we're having on GitHub? Comment at: clang/www/c_status.html:76 +The http

[PATCH] D116351: Update Bug report URL to Github Issues

asl requested changes to this revision. asl added a subscriber: tstellar. asl added a comment. This revision now requires changes to proceed. Thanks for doing this! I added few notes on the way. Comment at: clang/www/c_status.html:76 +The https://bugs.llvm.org/";>LLVM bug track

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Please see comments inline Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:43 +/// std::lower_bound is used to perform an efficient binary search on the data. +static

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe610932fa06: [MSP430][Clang] Remove support for -mmcu=msp430 (authored by jozefl, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108299/ne

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108299/new/ https://reviews.llvm.org/D108299

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

asl added a comment. Indeed! And even worse, there is another 'A' shadowing definition below :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98494/new/ https://reviews.llvm.org/D98494 ___ cfe-commits ma

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493 __

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

asl added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:582 + StringRef Linker = Args.getLastArgValue(options::OPT_fuse_ld_EQ, + CLANG_DEFAULT_LINKER); + if (Linker.empty()) How is CLANG_DEFAULT_LINKER

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. Looks trivial enough for post-commit review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98494/new/ https://reviews.llvm.org/D98494 _

[PATCH] D82646: [MSP430] Align the _Complex ABI with current msp430-gcc

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82646/new/ https://reviews.llvm.org/D82646

[PATCH] D82646: [MSP430] Align the _Complex ABI with current msp430-gcc

asl added inline comments. Comment at: clang/test/CodeGen/msp430-abi-complex.c:8 + +void complex_float_arg_first(float _Complex x, int n) { +// CHECK-LABEL: @complex_float_arg_first What's about Complex Int? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ee439b705e8: [builtins] Change si_int to int in some helper declarations (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4e8f7fe3f38: [builtins] Improve compatibility with 16 bit targets (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D82184: [MSP430] Update register names

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb56fa2196c5: [MSP430] Update register names (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82184/new/ https://r

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

This revision was automatically updated to reflect the committed changes. Closed by commit rGa931ec7ca0ee: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D82184: [MSP430] Update register names

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. Looks good to me! FP was an old register name from mspgcc time. MSP430 EABI does not use frame pointer at all (seems to be a bug in the ABI, as I do not understand how we could support VLAs or alloc

[PATCH] D82184: [MSP430] Update register names

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f6620f66303: [MSP430] Update register names (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82184/new/ https://r

[PATCH] D56927: Disable PIC/PIE for MSP430 target

This revision was automatically updated to reflect the committed changes. Closed by commit rL353877: Disable PIC/PIE for MSP430 target (authored by asl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https:

[PATCH] D56925: Do not use frame pointer by default for MSP430

This revision was automatically updated to reflect the committed changes. Closed by commit rL353212: Do not use frame pointer by default for MSP430 (authored by asl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST AC

[PATCH] D56925: Do not use frame pointer by default for MSP430

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. Herald added a project: clang. Ok now Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56925/new/ https://reviews.llvm.org/D56925 ___

[PATCH] D56927: Disable PIC/PIE for MSP430 target

asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Please make sure the test passes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D56927 _

[PATCH] D56927: Disable PIC/PIE for MSP430 target

asl reopened this revision. asl added a comment. This revision is now accepted and ready to land. The patch was reverted – the test requires fully configured msp430 configuration and therefore was breaking the bots. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D56927: Disable PIC/PIE for MSP430 target

This revision was automatically updated to reflect the committed changes. Closed by commit rC352181: Disable PIC/PIE for MSP430 target by default. (authored by asl, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D

[PATCH] D56925: Do not use frame pointer by default for MSP430

asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Patch fails to apply. Please rebase. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56925/new/ https://reviews.llvm.org/D56925 __

[PATCH] D57015: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI

This revision was automatically updated to reflect the committed changes. Closed by commit rC352177: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI (authored by asl, committed by ). Changed prior to commit: https://reviews.llvm.org/D57015?vs=182784&id=183492#toc Repository: rC Cla

[PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

asl accepted this revision. asl added a comment. Committed, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24461/new/ https://reviews.llvm.org/D24461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

This revision was automatically updated to reflect the committed changes. Closed by commit rL351449: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds (authored by asl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D2

[PATCH] D56663: [MSP430] Improve support of 'interrupt' attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL351344: [MSP430] Improve support of 'interrupt' attribute (authored by asl, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D56776: [MSP430] Fix msp430-toolchain.c on Windows (added in rL351228)

This revision was automatically updated to reflect the committed changes. Closed by commit rC351340: [MSP430] Fix msp430-toolchain.c on Windows (added in r351228) (authored by asl, committed by ). Changed prior to commit: https://reviews.llvm.org/D56776?vs=181998&id=182017#toc Repository: rC

[PATCH] D56658: [MSP430] Add msp430 toochain

asl added inline comments. Comment at: cfe/trunk/lib/CodeGen/CodeGenModule.cpp:141 + (!CodeGenOpts.RelaxedAliasing && CodeGenOpts.OptimizationLevel > 0)) { +fprintf(stderr, "TBAA enabled\n"); TBAA.reset(new CodeGenTBAA(Context, TheModule, CodeGenOpts, getLangOpts(),

[PATCH] D56658: [MSP430] Add msp430 toochain

asl added inline comments. Comment at: cfe/trunk/lib/CodeGen/CodeGenModule.cpp:141 + (!CodeGenOpts.RelaxedAliasing && CodeGenOpts.OptimizationLevel > 0)) { +fprintf(stderr, "TBAA enabled\n"); TBAA.reset(new CodeGenTBAA(Context, TheModule, CodeGenOpts, getLangOpts(),

[PATCH] D56658: [MSP430] Add msp430 toochain

This revision was automatically updated to reflect the committed changes. Closed by commit rL351228: [MSP430] Provide a toolchain description (authored by asl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56658?vs=181531&id=181841#t

[PATCH] D34440: [Clang] Expand response files before loading compilation database

asl added a comment. In https://reviews.llvm.org/D34440#809525, @alexfh wrote: > In https://reviews.llvm.org/D34440#808156, @vladimir.plyashkun wrote: > > > **To discuss:** > > ... > > By this moment, we unable to use //CompilationDatabase.json// from //CLion > > //side which is widely used in

[PATCH] D34562: [MSP430] Fix data layout string.

asl added a comment. Meta-question: shall we support only EABI or... 2 different ABIs? It seems it does not make any sense to support anything besides EABI. https://reviews.llvm.org/D34562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

This revision was automatically updated to reflect the committed changes. Closed by commit rL297005: Do not include GCC "resource" directory into the set of built-in include paths… (authored by asl). Changed prior to commit: https://reviews.llvm.org/D29464?vs=87827&id=90661#toc Repository: r

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. We shouldn't add resource dirs to the path. After all, these headers could use, for example, gcc-only extensions. https://reviews.llvm.org/D29464 ___

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

asl accepted this revision. asl added inline comments. This revision is now accepted and ready to land. Comment at: lib/Basic/Targets.cpp:8570 +} } don't you want to have "return false" here, just to silence warning for some compilers? https://reviews

[PATCH] D28346: [AVR] Allow specifying the CPU on the command line

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. LGTM with minor style nit Comment at: lib/Basic/Targets.cpp:8733 + auto It = std::find_if(AVRMcus.begin(), +AVRMcus.end(), +[&](const MCUInfo &Info) { return I

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

asl added inline comments. Comment at: test/CodeGen/avr-inline-asm-constraints.c:2 +// REQUIRES: avr-registered-target +// RUN: %clang_cc1 -triple avr-unknown-unknown -emit-llvm -o - %s | FileCheck %s + You need checks for multi-character stuff and unsupported c

[PATCH] D28346: [AVR] Allow specifying the CPU on the command line

asl added inline comments. Comment at: test/CodeGen/avr/target-cpu-defines/atmega328p.c:1 +// RUN: %clang_cc1 -triple avr-unknown-unknown -target-cpu atmega328p -emit-llvm %s -o - | FileCheck %s + This looks wrong. How you're using FileCheck? Consider dumping pr

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

asl requested changes to this revision. asl added inline comments. This revision now requires changes to proceed. Comment at: lib/Driver/MinGWToolChain.cpp:211 +#ifndef LLVM_ON_WIN32 if (GetRuntimeLibType(DriverArgs) == ToolChain::RLT_Libgcc) { This check is