[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

adukeman updated this revision to Diff 543659. adukeman added a comment. Update docs and run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155890/new/ https://reviews.llvm.org/D155890 Files: clang-tools-extra/docs/clang-tidy/checks

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

adukeman marked 3 inline comments as done. adukeman added a comment. Thanks for all the comments! I think I've got them all addressed and tests are passing locally. In D155890#4528560 , @carlosgalvezp wrote: > The review is marked as accepted, should w

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

adukeman updated this revision to Diff 543619. adukeman added a comment. Update calls to OptionalMemberCall to take a name matcher Supports treating calls to optional::has_value and optional::hasValue identically Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

adukeman added a comment. In D155890#4522266 , @ymandel wrote: > In D155890#4521266 , @carlosgalvezp > wrote: > >> This should be a configuration option, we should not hardcore >> project-specific things in the

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

adukeman created this revision. adukeman added reviewers: njames93, ymandel, sgatev. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. adukeman requested review of this revision. Herald added projects: clang, clang-tools-extra.