[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

2020-09-17 Thread Anthony Towns via Phabricator via cfe-commits
ajtowns added a comment. In D87629#2278580 , @aaronpuchert wrote: >> Not sure the `try { AssertHeld } catch (...) { a = 0; }` example reveals >> very much: it seems like thread safety annotations aren't checked within a >> catch block at all? >> `void g

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

2020-09-16 Thread Anthony Towns via Phabricator via cfe-commits
ajtowns added a comment. In D87629#2272676 , @aaronpuchert wrote: > (The existing `LockAssertion` class that the change removed looks like it > should use `ASSERT_CAPABILITY` instead—please don't use `ACQUIRE` when the > capability is assumed to be held